Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix readme for application insights in python #8979

Merged
merged 4 commits into from
Apr 8, 2020
Merged

fix readme for application insights in python #8979

merged 4 commits into from
Apr 8, 2020

Conversation

mmyyrroonn
Copy link
Contributor

Latest improvements:

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Contribution checklist:

  • I have reviewed the documentation for the workflow.
  • Validation tools were run on swagger spec(s) and have all been fixed in this PR.
  • The OpenAPI Hub was used for checking validation status and next steps.

ARM API Review Checklist

  • Service team MUST add the "WaitForARMFeedback" label if the management plane API changes fall into one of the below categories.
  • adding/removing APIs.
  • adding/removing properties.
  • adding/removing API-version.
  • adding a new service in Azure.

Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs.

  • If you are blocked on ARM review and want to get the PR merged urgently, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
    Please follow the link to find more details on API review process.

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@azuresdkci
Copy link
Contributor

Can one of the admins verify this patch?

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Apr 8, 2020 •
edited
Loading

azure-sdk-for-go - Release

️✔️ succeeded [Logs] [Expand Details]

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Apr 8, 2020 •
edited
Loading

azure-sdk-for-python - Release

⚠️ warning [Logs] [Expand Details]
  • ⚠️ Generate from 2977cf8 with merge commit 548d909. SDK Automation 13.0.17.20200326.3
  • ⚠️azure-mgmt-applicationinsights [Logs]  [Release SDK Changes] 
    [after_scripts|python] INFO:__main__:Default API version will be: v2020_03_01_preview
[build_package] /usr/lib/python3.6/distutils/dist.py:261: UserWarning: Unknown distribution option: 'long_description_content_type'
[build_package]   warnings.warn(msg)
[build_package] warning: no files found matching '*.py' under directory 'tests'
[build_package] warning: no files found matching '*.yaml' under directory 'tests'
[build_package] /usr/lib/python3.6/distutils/dist.py:261: UserWarning: Unknown distribution option: 'long_description_content_type'
[build_package]   warnings.warn(msg)
[build_package] warning: no files found matching '*.py' under directory 'tests'
[build_package] warning: no files found matching '*.yaml' under directory 'tests'
[breaking_change_setup] Ignoring mock: markers 'python_version <= "2.7"' don't match your environment
[breaking_change_setup] Cannot uninstall requirement azure-nspkg, not installed
[breaking_change_setup] Command '['/usr/local/bin/python', '-m', 'pip', 'uninstall', '-y', 'azure-nspkg']' returned non-zero exit status 1.
Not exact 2 reports found:
code_reports/0.2.0/report.json
code_reports/latest/merged_report.json
code_reports/latest/v2015_05_01.json
code_reports/latest/v2017_10_01.json
code_reports/latest/v2018_05_01_preview.json
code_reports/latest/v2018_06_17_preview.json
code_reports/latest/v2019_09_01_preview.json
code_reports/latest/v2019_10_17_preview.json
code_reports/latest/v2020_02_02_preview.json
code_reports/latest/v2020_03_01_preview.json
Not generating changelog.
[ChangeLog] WARNING: Failed to generate ChangeLog.

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Apr 8, 2020 •
edited
Loading

azure-sdk-for-net - Release

️✔️ succeeded [Logs] [Expand Details]
  • ️✔️ Generate from 2977cf8 with merge commit 548d909. SDK Automation 13.0.17.20200326.3
  • ️✔️Microsoft.Azure.ApplicationInsights [Logs]  [Release SDK Changes]
      No Artifact Generated.

    @openapi-sdkautomation
    Copy link

    openapi-sdkautomation bot commented Apr 8, 2020 •
    edited
    Loading

    azure-sdk-for-js - Release

    ️✔️ succeeded [Logs] [Expand Details]

    @openapi-sdkautomation
    Copy link

    openapi-sdkautomation bot commented Apr 8, 2020 •
    edited
    Loading

    azure-sdk-for-java - Release

    ️✔️ succeeded [Logs] [Expand Details]

    @openapi-sdkautomation
    Copy link

    openapi-sdkautomation bot commented Apr 8, 2020 •
    edited
    Loading

    azure-cli-extensions - Release

    No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured

    This was referenced Apr 8, 2020
    Closed
    Closed
    Closed
    Closed
    @azure-pipelines
    Copy link

    Azure Pipelines successfully started running 1 pipeline(s).

    @azure-pipelines
    Copy link

    Azure Pipelines successfully started running 1 pipeline(s).

    qiaozha
    qiaozha reviewed Apr 8, 2020
    View reviewed changes
    specification/applicationinsights/resource-manager/readme.md Outdated Show resolved Hide resolved
    specification/applicationinsights/resource-manager/readme.python.md

    ``` yaml $(python)
    python-mode: create
    Copy link
    Member

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    to remove python-mode: create is just a temporary solution for az. I suggest you hold on.

    Copy link
    Contributor

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    Just for SDK, @myronfanqiu please revert this change

    Copy link
    Contributor Author

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    Done. Please check other part. You can directly modify these files since I just got this file from wei dong. I don't have full knowledge as well.

    @azure-pipelines
    Copy link

    Azure Pipelines successfully started running 1 pipeline(s).

    qiaozha
    qiaozha reviewed Apr 8, 2020
    View reviewed changes
    specification/applicationinsights/resource-manager/readme.python.md
    ```
    ``` yaml $(python) && $(python-mode) == 'update'
    Copy link
    Member

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    Should this also need to be revert?

    qiaozha
    qiaozha reviewed Apr 8, 2020
    View reviewed changes
    specification/applicationinsights/resource-manager/readme.python.md
    ```
    ``` yaml $(python) && $(python-mode) == 'create'
    Copy link
    Member

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    also here

    zikalino
    zikalino reviewed Apr 8, 2020
    View reviewed changes
    specification/applicationinsights/resource-manager/readme.python.md
    ``` yaml $(python) && $(multiapi)
    batch:
    - tag: package-2015-05
    - tag: package-2017-10
    Copy link

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    usually we put most recent versions on the top

    zikalino
    zikalino reviewed Apr 8, 2020
    View reviewed changes
    specification/applicationinsights/resource-manager/readme.python.md
    ```
    ``` yaml $(python) && $(python-mode) == 'update'

    ### Tag: package-2015-05 and python
    Copy link

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    same here, most recent on the top

    @zikalino zikalino merged commit 548d909 into Azure:master Apr 8, 2020
    00Kai0 pushed a commit to 00Kai0/azure-rest-api-specs that referenced this pull request Oct 12, 2020
    @mmyyrroonn @00Kai0
    fix readme for application insights in python (Azure#8979)
    b4a9b9e 
    * fix readme

* fix

* fix

* reveert
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Reviewers

    @LianwMS LianwMS LianwMS left review comments

    @qiaozha qiaozha qiaozha left review comments

    @zikalino zikalino zikalino approved these changes

    Assignees

    @mmyyrroonn mmyyrroonn

    Labels
    None yet
    Projects
    None yet
    Milestone
    No milestone
    Development

    Successfully merging this pull request may close these issues.
    5 participants
    @mmyyrroonn @azuresdkci @LianwMS @zikalino @qiaozha