Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Ready For Review] Add APIs for preparing Azure Notebook to newer version #9716

Merged
merged 4 commits into from
Jun 11, 2020

Conversation

zhaomuzhi
Copy link
Contributor

@zhaomuzhi zhaomuzhi commented Jun 4, 2020

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Contribution checklist:

If any further question about AME onboarding or validation tools, please view the FAQ.

ARM API Review Checklist

  • Service team MUST add the "WaitForARMFeedback" label if the management plane API changes fall into one of the below categories.
    • adding/removing APIs.
    • adding/removing properties.
    • adding/removing API-version.
    • adding a new service in Azure.

Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs.

  • If you are blocked on ARM review and want to get the PR merged urgently, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
    Please follow the link to find more details on API review process.

@openapi-pipeline-app
Copy link

openapi-pipeline-app bot commented Jun 4, 2020

[Staging] Swagger Validation Report

~[Staging] BreakingChange: 1 Errors, 0 Warnings [Detail][Expand Details]
Rule Message
1041 - AddedPropertyInResponse The new version has a new property 'notebookAccessKeys' in response that was not found in the old version.
New: Microsoft.MachineLearningServices/stable/2020-04-01/machineLearningServices.json#L2129:7
Old: Microsoft.MachineLearningServices/stable/2020-04-01/machineLearningServices.json#L2037:7
Posted by Swagger Pipeline

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@openapi-assignment-bot openapi-assignment-bot bot added the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Jun 4, 2020
@azuresdkci
Copy link
Contributor

Can one of the admins verify this patch?

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Jun 4, 2020

azure-sdk-for-net - Release

️✔️ succeeded [Logs] [Expand Details]
  • ️✔️ Generate from 1cb7892 with merge commit 92e846e. SDK Automation 13.0.17.20200605.3
    [AutoRest] realpath(): Permission denied
    [AutoRest] realpath(): Permission denied
    [AutoRest] realpath(): Permission denied
    [AutoRest] realpath(): Permission denied
    [AutoRest] realpath(): Permission denied
    [AutoRest] realpath(): Permission denied
  • ️✔️Microsoft.Azure.Management.MachineLearningServices [View full logs]  [Release SDK Changes]
      No Artifact Generated.

    @openapi-sdkautomation
    Copy link

    openapi-sdkautomation bot commented Jun 4, 2020

    Azure CLI Extension Generation - Release

    • Installation instruction for service machinelearningservices [Preview Changes]
      az extension add --source=https://sdkautomation.blob.core.windows.net/sdkautomation-pipeline/Azure/azure-rest-api-specs/9716/azure-cli-extensions/Azure/azure-cli-extensions/machinelearningservices/machinelearningservices-0.1.0-py3-none-any.whl
    ️✔️ succeeded [Logs] [Expand Details]
    • ️✔️ Generate from 1cb7892 with merge commit 92e846e. Azure CLI Automation 13.0.17.20200605.3
      Only show 100 items here, please refer to log for details.
      [AutoRest] WARNING (PreCheck/AllOfWhenYouMeantRef): Schema 'DataFactory' is using an 'allOf' instead of a $ref. This creates a wasteful anonymous type when generating code.
      [AutoRest] WARNING (PreCheck/SchemaMissingType): The schema 'Operation-display' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
      [AutoRest] WARNING (PreCheck/SchemaMissingType): The schema 'OperationListResult' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
      [AutoRest] WARNING (PreCheck/SchemaMissingType): The schema 'WorkspaceUpdateParameters' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
      [AutoRest] WARNING (PreCheck/SchemaMissingType): The schema 'WorkspacePropertiesUpdateParameters' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
      [AutoRest] WARNING (PreCheck/SchemaMissingType): The schema 'ListAmlUserFeatureResult' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
      [AutoRest] WARNING (PreCheck/SchemaMissingType): The schema 'UsageName' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
      [AutoRest] WARNING (PreCheck/SchemaMissingType): The schema 'ListUsagesResult' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
      [AutoRest] WARNING (PreCheck/SchemaMissingType): The schema 'VirtualMachineSize' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
      [AutoRest] WARNING (PreCheck/SchemaMissingType): The schema 'VirtualMachineSizeListResult' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
      [AutoRest] WARNING (PreCheck/SchemaMissingType): The schema 'WorkspaceListResult' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
      [AutoRest] WARNING (PreCheck/SchemaMissingType): The schema 'QuotaBaseProperties' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
      [AutoRest] WARNING (PreCheck/SchemaMissingType): The schema 'QuotaUpdateParameters' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
      [AutoRest] WARNING (PreCheck/SchemaMissingType): The schema 'UpdateWorkspaceQuotasResult' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
      [AutoRest] WARNING (PreCheck/SchemaMissingType): The schema 'UpdateWorkspaceQuotas' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
      [AutoRest] WARNING (PreCheck/SchemaMissingType): The schema 'ResourceName' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
      [AutoRest] WARNING (PreCheck/SchemaMissingType): The schema 'ResourceQuota' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
      [AutoRest] WARNING (PreCheck/SchemaMissingType): The schema 'ListWorkspaceQuotas' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
      [AutoRest] WARNING (PreCheck/SchemaMissingType): The schema 'Identity' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
      [AutoRest] WARNING (PreCheck/SchemaMissingType): The schema 'Resource' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
      [AutoRest] WARNING (PreCheck/SchemaMissingType): The schema 'ResourceId' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
      [AutoRest] WARNING (PreCheck/SchemaMissingType): The schema 'DataFactory' with an undefined type and 'allOf'/'anyOf'/'oneOf' is a bit ambigious. This has been auto-corrected to 'type:object'
      [AutoRest] WARNING (PreCheck/SchemaMissingType): The schema 'UserAccountCredentials' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
      [AutoRest] WARNING (PreCheck/SchemaMissingType): The schema 'NodeStateCounts' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
      [AutoRest] WARNING (PreCheck/SchemaMissingType): The schema 'ClusterUpdateProperties' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
      [AutoRest] WARNING (PreCheck/SchemaMissingType): The schema 'ClusterUpdateParameters' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
      [AutoRest] WARNING (PreCheck/SchemaMissingType): The schema 'AmlComputeNodeInformation' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
      [AutoRest] WARNING (PreCheck/SchemaMissingType): The schema 'ResourceSkuLocationInfo' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
      [AutoRest] WARNING (PreCheck/SchemaMissingType): The schema 'ResourceSkuZoneDetails' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
      [AutoRest] WARNING (PreCheck/SchemaMissingType): The schema 'Restriction' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
      [AutoRest] WARNING (PreCheck/SchemaMissingType): The schema 'PrivateEndpointConnection' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
      [AutoRest] WARNING (PreCheck/SchemaMissingType): The schema 'PrivateEndpointConnectionProperties' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
      [AutoRest] WARNING (PreCheck/SchemaMissingType): The schema 'PrivateEndpoint' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
      [AutoRest] WARNING (PreCheck/SchemaMissingType): The schema 'PrivateLinkServiceConnectionState' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
      [AutoRest] WARNING (PreCheck/SchemaMissingType): The schema 'PrivateLinkResourceListResult' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
      [AutoRest] WARNING (PreCheck/SchemaMissingType): The schema 'PrivateLinkResource' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
      [AutoRest] WARNING (PreCheck/SchemaMissingType): The schema 'PrivateLinkResourceProperties' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
      [AutoRest] WARNING (PreCheck/SchemaMissingType): The schema 'SharedPrivateLinkResource' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
      [AutoRest] WARNING (PreCheck/SchemaMissingType): The schema 'SharedPrivateLinkResourceProperty' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
      [AutoRest] WARNING (): cli.auto-parameter-hidden is not true, skip visibility cleaner
      [AutoRest] WARNING: parameter properties has two different references but they have the same flattened name
      [AutoRest] WARNING: parameter properties has two different references but they have the same flattened name
      [AutoRest] 
      [AutoRest] NO TEST SCENARIO PROVIDED - DEFAULT WILL BE USED
      [AutoRest] ADD FOLLOWING SECTION TO readme.cli.md FILE TO MODIFY IT
      [AutoRest] --------------------------------------------------------
      [AutoRest]   test-scenario:
      [AutoRest]     - name: /MachineLearningCompute/put/Create AKS Compute
      [AutoRest]     - name: /MachineLearningCompute/put/Create AKS Compute
      [AutoRest]     - name: /MachineLearningCompute/put/Create AKS Compute
      [AutoRest]     - name: /MachineLearningCompute/put/Create AKS Compute
      [AutoRest]     - name: /MachineLearningCompute/put/Create AKS Compute
      [AutoRest]     - name: /MachineLearningCompute/put/Create AKS Compute
      [AutoRest]     - name: /MachineLearningCompute/put/Create AKS Compute
      [AutoRest]     - name: /MachineLearningCompute/put/Create a AML Compute
      [AutoRest]     - name: /MachineLearningCompute/put/Create a AML Compute
      [AutoRest]     - name: /MachineLearningCompute/put/Create a AML Compute
      [AutoRest]     - name: /MachineLearningCompute/put/Create a AML Compute
      [AutoRest]     - name: /MachineLearningCompute/put/Create a AML Compute
      [AutoRest]     - name: /MachineLearningCompute/put/Create a AML Compute
      [AutoRest]     - name: /MachineLearningCompute/put/Create a AML Compute
      [AutoRest]     - name: /MachineLearningCompute/put/Create a DataFactory Compute
      [AutoRest]     - name: /MachineLearningCompute/put/Create a DataFactory Compute
      [AutoRest]     - name: /MachineLearningCompute/put/Create a DataFactory Compute
      [AutoRest]     - name: /MachineLearningCompute/put/Create a DataFactory Compute
      [AutoRest]     - name: /MachineLearningCompute/put/Create a DataFactory Compute
      [AutoRest]     - name: /MachineLearningCompute/put/Create a DataFactory Compute
      [AutoRest]     - name: /MachineLearningCompute/put/Create a DataFactory Compute
      [AutoRest]     - name: /MachineLearningCompute/put/Update a AKS Compute
      [AutoRest]     - name: /MachineLearningCompute/put/Update a AKS Compute
      [AutoRest]     - name: /MachineLearningCompute/put/Update a AKS Compute
      [AutoRest]     - name: /MachineLearningCompute/put/Update a AKS Compute
      [AutoRest]     - name: /MachineLearningCompute/put/Update a AKS Compute
      [AutoRest]     - name: /MachineLearningCompute/put/Update a AKS Compute
      [AutoRest]     - name: /MachineLearningCompute/put/Update a AKS Compute
      [AutoRest]     - name: /MachineLearningCompute/put/Update a AML Compute
      [AutoRest]     - name: /MachineLearningCompute/put/Update a AML Compute
      [AutoRest]     - name: /MachineLearningCompute/put/Update a AML Compute
      [AutoRest]     - name: /MachineLearningCompute/put/Update a AML Compute
      [AutoRest]     - name: /MachineLearningCompute/put/Update a AML Compute
      [AutoRest]     - name: /MachineLearningCompute/put/Update a AML Compute
      [AutoRest]     - name: /MachineLearningCompute/put/Update a AML Compute
      [AutoRest]     - name: /MachineLearningCompute/get/Get Computes
      [AutoRest]     - name: /MachineLearningCompute/get/Get a AKS Compute
      [AutoRest]     - name: /MachineLearningCompute/get/Get a AML Compute
      [AutoRest]     - name: /MachineLearningCompute/post/Get compute nodes information for a compute
      [AutoRest]     - name: /MachineLearningCompute/post/List AKS Compute Keys
      [AutoRest]     - name: /MachineLearningCompute/patch/Update a AmlCompute Compute
      [AutoRest]     - name: /Notebooks/post/Prepare Notebook
      [AutoRest]     - name: /PrivateEndpointConnections/put/WorkspacePutPrivateEndpointConnection
      [AutoRest]     - name: /PrivateEndpointConnections/get/WorkspaceGetPrivateEndpointConnection
      [AutoRest]     - name: /PrivateLinkResources/get/WorkspaceListPrivateLinkResources
      [AutoRest]     - name: /Quotas/get/List workspace quotas by VMFamily
      [AutoRest]     - name: /Quotas/post/update quotas
      [AutoRest]     - name: /Usages/get/List Usages
      [AutoRest]     - name: /VirtualMachineSizes/get/List VM Sizes
      [AutoRest]     - name: /WorkspaceFeatures/get/List Workspace features
      [AutoRest]     - name: /Workspaces/put/Create Workspace
      [AutoRest]     - name: /Workspaces/get/Get Workspace
      [AutoRest]     - name: /Workspaces/get/Get Workspaces by Resource Group
    • ️✔️machinelearningservices [View full logs]  [Release Azure CLI Changes]

    @openapi-sdkautomation
    Copy link

    openapi-sdkautomation bot commented Jun 4, 2020

    azure-sdk-for-js - Release

    ️✔️ succeeded [Logs] [Expand Details]
    • ️✔️ Generate from 1cb7892 with merge commit 92e846e. SDK Automation 13.0.17.20200605.3
    • ️✔️@azure/arm-machinelearningservices [View full logs]  [Release SDK Changes]
      Only show 100 items here, please refer to log for details.
      [npmPack] npm WARN deprecated [email protected]: This package has been deprecated and is no longer maintained. Please use @rollup/plugin-node-resolve.
      [npmPack] npm WARN deprecated [email protected]: https://github.com/lydell/resolve-url#deprecated
      [npmPack] npm WARN deprecated [email protected]: Please see https://github.com/lydell/urix#deprecated
      [npmPack] npm notice created a lockfile as package-lock.json. You should commit this file.
      [npmPack] loaded rollup.config.js with warnings
      [npmPack] (!) Unused external imports
      [npmPack] default imported from external module 'rollup' but never used
      [npmPack] 
      [npmPack] ./esm/azureMachineLearningWorkspaces.js → ./dist/arm-machinelearningservices.js...
      [npmPack] created ./dist/arm-machinelearningservices.js in 403ms
      [npmPack] npm notice 
      [npmPack] npm notice package: @azure/[email protected]
      [npmPack] npm notice === Tarball Contents === 
      [npmPack] npm notice 166.6kB dist/arm-machinelearningservices.js                  
      [npmPack] npm notice 59.3kB  dist/arm-machinelearningservices.min.js              
      [npmPack] npm notice 3.9kB   esm/azureMachineLearningWorkspaces.js                
      [npmPack] npm notice 2.6kB   esm/azureMachineLearningWorkspacesContext.js         
      [npmPack] npm notice 345B    esm/models/index.js                                  
      [npmPack] npm notice 696B    esm/operations/index.js                              
      [npmPack] npm notice 15.2kB  esm/operations/machineLearningCompute.js             
      [npmPack] npm notice 1.5kB   esm/models/machineLearningComputeMappers.js          
      [npmPack] npm notice 74.9kB  esm/models/mappers.js                                
      [npmPack] npm notice 2.8kB   esm/operations/notebooks.js                          
      [npmPack] npm notice 513B    esm/models/notebooksMappers.js                       
      [npmPack] npm notice 1.6kB   esm/operations/operations.js                         
      [npmPack] npm notice 516B    esm/models/operationsMappers.js                      
      [npmPack] npm notice 2.8kB   esm/models/parameters.js                             
      [npmPack] npm notice 4.9kB   esm/operations/privateEndpointConnections.js         
      [npmPack] npm notice 1.2kB   esm/models/privateEndpointConnectionsMappers.js      
      [npmPack] npm notice 2.1kB   esm/operations/privateLinkResources.js               
      [npmPack] npm notice 1.2kB   esm/models/privateLinkResourcesMappers.js            
      [npmPack] npm notice 3.5kB   esm/operations/quotas.js                             
      [npmPack] npm notice 620B    esm/models/quotasMappers.js                          
      [npmPack] npm notice 1.0kB   rollup.config.js                                     
      [npmPack] npm notice 2.4kB   esm/operations/usages.js                             
      [npmPack] npm notice 453B    esm/models/usagesMappers.js                          
      [npmPack] npm notice 1.8kB   esm/operations/virtualMachineSizes.js                
      [npmPack] npm notice 480B    esm/models/virtualMachineSizesMappers.js             
      [npmPack] npm notice 2.7kB   esm/operations/workspaceFeatures.js                  
      [npmPack] npm notice 515B    esm/models/workspaceFeaturesMappers.js               
      [npmPack] npm notice 11.9kB  esm/operations/workspaces.js                         
      [npmPack] npm notice 1.3kB   esm/models/workspacesMappers.js                      
      [npmPack] npm notice 1.8kB   package.json                                         
      [npmPack] npm notice 457B    tsconfig.json                                        
      [npmPack] npm notice 335.9kB dist/arm-machinelearningservices.js.map              
      [npmPack] npm notice 48.2kB  dist/arm-machinelearningservices.min.js.map          
      [npmPack] npm notice 1.7kB   esm/azureMachineLearningWorkspaces.d.ts.map          
      [npmPack] npm notice 2.4kB   esm/azureMachineLearningWorkspaces.js.map            
      [npmPack] npm notice 526B    esm/azureMachineLearningWorkspacesContext.d.ts.map   
      [npmPack] npm notice 1.4kB   esm/azureMachineLearningWorkspacesContext.js.map     
      [npmPack] npm notice 26.8kB  esm/models/index.d.ts.map                            
      [npmPack] npm notice 336B    esm/operations/index.d.ts.map                        
      [npmPack] npm notice 126B    esm/models/index.js.map                              
      [npmPack] npm notice 351B    esm/operations/index.js.map                          
      [npmPack] npm notice 3.9kB   esm/operations/machineLearningCompute.d.ts.map       
      [npmPack] npm notice 6.7kB   esm/operations/machineLearningCompute.js.map         
      [npmPack] npm notice 813B    esm/models/machineLearningComputeMappers.d.ts.map    
      [npmPack] npm notice 826B    esm/models/machineLearningComputeMappers.js.map      
      [npmPack] npm notice 4.2kB   esm/models/mappers.d.ts.map                          
      [npmPack] npm notice 42.3kB  esm/models/mappers.js.map                            
      [npmPack] npm notice 670B    esm/operations/notebooks.d.ts.map                    
      [npmPack] npm notice 1.3kB   esm/operations/notebooks.js.map                      
      [npmPack] npm notice 236B    esm/models/notebooksMappers.d.ts.map                 
      [npmPack] npm notice 249B    esm/models/notebooksMappers.js.map                   
      [npmPack] npm notice 663B    esm/operations/operations.d.ts.map                   
      [npmPack] npm notice 910B    esm/operations/operations.js.map                     
      [npmPack] npm notice 248B    esm/models/operationsMappers.d.ts.map                
      [npmPack] npm notice 261B    esm/models/operationsMappers.js.map                  
      [npmPack] npm notice 684B    esm/models/parameters.d.ts.map                       
      [npmPack] npm notice 2.0kB   esm/models/parameters.js.map                         
      [npmPack] npm notice 2.0kB   esm/operations/privateEndpointConnections.d.ts.map   
      [npmPack] npm notice 2.5kB   esm/operations/privateEndpointConnections.js.map     
      [npmPack] npm notice 681B    esm/models/privateEndpointConnectionsMappers.d.ts.map
      [npmPack] npm notice 694B    esm/models/privateEndpointConnectionsMappers.js.map  
      [npmPack] npm notice 817B    esm/operations/privateLinkResources.d.ts.map         
      [npmPack] npm notice 1.1kB   esm/operations/privateLinkResources.js.map           
      [npmPack] npm notice 692B    esm/models/privateLinkResourcesMappers.d.ts.map      
      [npmPack] npm notice 705B    esm/models/privateLinkResourcesMappers.js.map        
      [npmPack] npm notice 1.6kB   esm/operations/quotas.d.ts.map                       
      [npmPack] npm notice 2.2kB   esm/operations/quotas.js.map                         
      [npmPack] npm notice 299B    esm/models/quotasMappers.d.ts.map                    
      [npmPack] npm notice 312B    esm/models/quotasMappers.js.map                      
      [npmPack] npm notice 1.1kB   esm/operations/usages.d.ts.map                       
      [npmPack] npm notice 1.5kB   esm/operations/usages.js.map                         
      [npmPack] npm notice 214B    esm/models/usagesMappers.d.ts.map                    
      [npmPack] npm notice 227B    esm/models/usagesMappers.js.map                      
      [npmPack] npm notice 746B    esm/operations/virtualMachineSizes.d.ts.map          
      [npmPack] npm notice 1.0kB   esm/operations/virtualMachineSizes.js.map            
      [npmPack] npm notice 233B    esm/models/virtualMachineSizesMappers.d.ts.map       
      [npmPack] npm notice 246B    esm/models/virtualMachineSizesMappers.js.map         
      [npmPack] npm notice 1.2kB   esm/operations/workspaceFeatures.d.ts.map            
      [npmPack] npm notice 1.6kB   esm/operations/workspaceFeatures.js.map              
      [npmPack] npm notice 249B    esm/models/workspaceFeaturesMappers.d.ts.map         
      [npmPack] npm notice 262B    esm/models/workspaceFeaturesMappers.js.map           
      [npmPack] npm notice 4.4kB   esm/operations/workspaces.d.ts.map                   
      [npmPack] npm notice 6.6kB   esm/operations/workspaces.js.map                     
      [npmPack] npm notice 724B    esm/models/workspacesMappers.d.ts.map                
      [npmPack] npm notice 737B    esm/models/workspacesMappers.js.map                  
      [npmPack] npm notice 3.3kB   README.md                                            
      [npmPack] npm notice 3.1kB   esm/azureMachineLearningWorkspaces.d.ts              

    @openapi-sdkautomation
    Copy link

    openapi-sdkautomation bot commented Jun 4, 2020

    azure-sdk-for-python - Release

    - Breaking Change detected in SDK

    ⚠️ warning [Logs] [Expand Details]
    • ⚠️ Generate from 1cb7892 with merge commit 92e846e. SDK Automation 13.0.17.20200605.3
    • ⚠️azure-mgmt-machinelearningservices [View full logs]  [Release SDK Changes] Breaking Change Detected
      [build_conf] INFO:packaging_tools:Building template azure-mgmt-machinelearningservices
      [build_conf] INFO:packaging_tools.conf:Skipping default conf since the file exists
      [build_conf] INFO:packaging_tools:Skipping CHANGELOG.md template, since a previous one was found
      [build_conf] INFO:packaging_tools:Template done azure-mgmt-machinelearningservices
      [build_package] /usr/lib/python3.6/distutils/dist.py:261: UserWarning: Unknown distribution option: 'long_description_content_type'
      [build_package]   warnings.warn(msg)
      [build_package] warning: no files found matching '*.py' under directory 'tests'
      [build_package] warning: no files found matching '*.yaml' under directory 'tests'
      [build_package] /usr/lib/python3.6/distutils/dist.py:261: UserWarning: Unknown distribution option: 'long_description_content_type'
      [build_package]   warnings.warn(msg)
      [build_package] warning: no files found matching '*.py' under directory 'tests'
      [build_package] warning: no files found matching '*.yaml' under directory 'tests'
      [breaking_change_setup] Ignoring mock: markers 'python_version <= "2.7"' don't match your environment
      [ChangeLog] Size of delta 38.840% size of original (original: 52467 chars, delta: 20378 chars)
      [ChangeLog] **Features**
      [ChangeLog] 
      [ChangeLog]   - Model Identity has a new parameter user_assigned_identities
      [ChangeLog]   - Model ListWorkspaceKeysResult has a new parameter notebook_access_keys
      [ChangeLog]   - Model ComputeResource has a new parameter sku
      [ChangeLog]   - Model Resource has a new parameter sku
      [ChangeLog]   - Model Workspace has a new parameter private_endpoint_connections
      [ChangeLog]   - Model Workspace has a new parameter shared_private_link_resources
      [ChangeLog]   - Model Workspace has a new parameter encryption
      [ChangeLog]   - Model Workspace has a new parameter hbi_workspace
      [ChangeLog]   - Model Workspace has a new parameter sku
      [ChangeLog]   - Model Workspace has a new parameter allow_public_access_when_behind_vnet
      [ChangeLog]   - Model Workspace has a new parameter service_provisioned_resource_group
      [ChangeLog]   - Model Workspace has a new parameter private_link_count
      [ChangeLog]   - Model Workspace has a new parameter image_build_compute
      [ChangeLog]   - Model Workspace has a new parameter notebook_info
      [ChangeLog]   - Model AmlComputeProperties has a new parameter remote_login_port_public_access
      [ChangeLog]   - Model WorkspaceUpdateParameters has a new parameter sku
      [ChangeLog]   - Model VirtualMachineSize has a new parameter gpus
      [ChangeLog]   - Added operation group AzureMachineLearningWorkspacesOperationsMixin
      [ChangeLog]   - Added operation group PrivateLinkResourcesOperations
      [ChangeLog]   - Added operation group QuotasOperations
      [ChangeLog]   - Added operation group NotebooksOperations
      [ChangeLog]   - Added operation group PrivateEndpointConnectionsOperations
      [ChangeLog]   - Added operation group WorkspaceFeaturesOperations
      [ChangeLog] 
      [ChangeLog] **Breaking changes**
      [ChangeLog] 
      [ChangeLog]   - Parameter type of model Identity is now required
      [ChangeLog]   - Model AmlComputeNodeInformation has a new signature

    @openapi-sdkautomation
    Copy link

    openapi-sdkautomation bot commented Jun 4, 2020

    azure-sdk-for-java - Release

    No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured

    @openapi-sdkautomation
    Copy link

    openapi-sdkautomation bot commented Jun 4, 2020

    Trenton Generation - Release

    No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured

    @openapi-sdkautomation
    Copy link

    openapi-sdkautomation bot commented Jun 4, 2020

    azure-sdk-for-python-track2 - Release

    No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured

    @openapi-sdkautomation
    Copy link

    openapi-sdkautomation bot commented Jun 4, 2020

    azure-sdk-for-go - Release

    ️✔️ succeeded [Logs] [Expand Details]

    @@ -300,6 +300,54 @@
    }
    }
    },
    "/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.MachineLearningServices/workspaces/{workspaceName}/prepareNotebook": {
    Copy link
    Contributor Author

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    This change has been added to version 2020-03-01 by this change #9058, but 2020-04-01 is missing it. So added the same change to version "2020-04-01"

    @majastrz majastrz added ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review and removed WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required labels Jun 9, 2020
    Copy link
    Member

    @majastrz majastrz left a comment

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    Signed off from ARM side.

    @ArcturusZhang ArcturusZhang added the Approved-BreakingChange DO NOT USE! OBSOLETE label. See https://github.com/Azure/azure-sdk-tools/issues/6374 label Jun 10, 2020
    @ArcturusZhang
    Copy link
    Member

    Hi @akning-ms could you please help us merge this PR?

    00Kai0 pushed a commit to 00Kai0/azure-rest-api-specs that referenced this pull request Oct 12, 2020
    …sion (Azure#9716)
    
    * Add Identity to createWorkpace example
    
    * move missing apis to version 2020-04-01
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Labels
    Approved-BreakingChange DO NOT USE! OBSOLETE label. See https://github.com/Azure/azure-sdk-tools/issues/6374 ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review potential-sdk-breaking-change
    Projects
    None yet
    Development

    Successfully merging this pull request may close these issues.

    5 participants