-
Notifications
You must be signed in to change notification settings - Fork 5.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cosmos DB remove 404 response on databaseAccounts GET #9746
Conversation
…ccount does not exist
[Staging] Swagger Validation Report
❌ |
Rule | Message |
---|---|
1012 - RemovedResponseCode |
The new version removes the response code '404' Old: Microsoft.DocumentDB/stable/2020-03-01/cosmos-db.json#L67:11 |
1012 - RemovedResponseCode |
The new version removes the response code '404' Old: Microsoft.DocumentDB/stable/2020-04-01/cosmos-db.json#L67:11 |
Azure Pipelines successfully started running 1 pipeline(s). |
Can one of the admins verify this patch? |
azure-sdk-for-go - Release
|
Azure CLI Extension Generation - Release
No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured
|
azure-sdk-for-js - Release
|
azure-sdk-for-java - Release
|
azure-sdk-for-python - Release
|
azure-sdk-for-python-track2 - Release
No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured
|
azure-sdk-for-net - Release
No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured
|
Trenton Generation - Release
No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured
|
@shurd pls fix the model validation error. Does the PR fix the sdk or cli bug? |
Azure Pipelines successfully started running 1 pipeline(s). |
@ruowan This change causes the SDK to throw an exception when the resource is not found, which is the expected behavior. We previously had this behavior, but mistakenly added 404 as an "ok" response. Right now, SDK users will just get "null" if the resource does not exist. This can cause problems if users (such as the CLI) were expected an exception. |
Ok. I put Approved-BreakingChange. Is the PR ready to merge? |
Yes, thanks |
@Juliehzl for awareness |
* removing documented 404 to prevent swallowing exception in CLI when account does not exist * removing 404 response code from examples Co-authored-by: Sam Hurd <[email protected]>
Removing documented 404 responses on database account "GET" so that generated SDKs throw exception on this response. This is required to fix a scenario in the CLI where methods are continuing with a NoneType object
MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.
Contribution checklist:
If any further question about AME onboarding or validation tools, please view the FAQ.
ARM API Review Checklist
Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs.
Please follow the link to find more details on API review process.