add tags type #9763

changlong-liu · 2020-06-08T05:23:00Z

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Contribution checklist:

I have reviewed the documentation for the workflow.
Validation tools were run on swagger spec(s) and have all been fixed in this PR. How to fix?

If any further question about AME onboarding or validation tools, please view the FAQ.

ARM API Review Checklist

Service team MUST add the "WaitForARMFeedback" label if the management plane API changes fall into one of the below categories.
- adding/removing APIs.
- adding/removing properties.
- adding/removing API-version.
- adding a new service in Azure.

Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs.

If you are blocked on ARM review and want to get the PR merged urgently, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
Please follow the link to find more details on API review process.

openapi-pipeline-app · 2020-06-08T05:23:04Z

[Staging] Swagger Validation Report

️❌~[Staging] BreakingChange: 10 Errors, 0 Warnings [Detail][Expand Details]

Rule	Message
`❌` 1021 - AddedAdditionalProperties	The new version adds an 'additionalProperties' element. New: Microsoft.DesktopVirtualization/preview/2019-12-10-preview/desktopvirtualization.json#L2693:9 Old: Microsoft.DesktopVirtualization/preview/2019-12-10-preview/desktopvirtualization.json#L2681:9
`❌` 1021 - AddedAdditionalProperties	The new version adds an 'additionalProperties' element. New: Microsoft.DesktopVirtualization/preview/2019-12-10-preview/desktopvirtualization.json#L2024:9 Old: Microsoft.DesktopVirtualization/preview/2019-12-10-preview/desktopvirtualization.json#L2024:9
`❌` 1021 - AddedAdditionalProperties	The new version adds an 'additionalProperties' element. New: Microsoft.DesktopVirtualization/preview/2019-12-10-preview/desktopvirtualization.json#L2129:9 Old: Microsoft.DesktopVirtualization/preview/2019-12-10-preview/desktopvirtualization.json#L2126:9
`❌` 1021 - AddedAdditionalProperties	The new version adds an 'additionalProperties' element. New: Microsoft.DesktopVirtualization/preview/2019-12-10-preview/desktopvirtualization.json#L2568:9 Old: Microsoft.DesktopVirtualization/preview/2019-12-10-preview/desktopvirtualization.json#L2559:9
`❌` 1021 - AddedAdditionalProperties	The new version adds an 'additionalProperties' element. New: Microsoft.DesktopVirtualization/preview/2019-12-10-preview/desktopvirtualization.json#L2693:9 Old: Microsoft.DesktopVirtualization/preview/2019-12-10-preview/desktopvirtualization.json#L2681:9
`❌` 1021 - AddedAdditionalProperties	The new version adds an 'additionalProperties' element. New: Microsoft.DesktopVirtualization/preview/2019-12-10-preview/desktopvirtualization.json#L2300:9 Old: Microsoft.DesktopVirtualization/preview/2019-12-10-preview/desktopvirtualization.json#L2294:9
`❌` 1021 - AddedAdditionalProperties	The new version adds an 'additionalProperties' element. New: Microsoft.DesktopVirtualization/preview/2019-12-10-preview/desktopvirtualization.json#L2024:9 Old: Microsoft.DesktopVirtualization/preview/2019-12-10-preview/desktopvirtualization.json#L2024:9
`❌` 1021 - AddedAdditionalProperties	The new version adds an 'additionalProperties' element. New: Microsoft.DesktopVirtualization/preview/2019-12-10-preview/desktopvirtualization.json#L2129:9 Old: Microsoft.DesktopVirtualization/preview/2019-12-10-preview/desktopvirtualization.json#L2126:9
`❌` 1021 - AddedAdditionalProperties	The new version adds an 'additionalProperties' element. New: Microsoft.DesktopVirtualization/preview/2019-12-10-preview/desktopvirtualization.json#L2300:9 Old: Microsoft.DesktopVirtualization/preview/2019-12-10-preview/desktopvirtualization.json#L2294:9
`❌` 1021 - AddedAdditionalProperties	The new version adds an 'additionalProperties' element. New: Microsoft.DesktopVirtualization/preview/2019-12-10-preview/desktopvirtualization.json#L2568:9 Old: Microsoft.DesktopVirtualization/preview/2019-12-10-preview/desktopvirtualization.json#L2559:9

_{Posted by Swagger Pipeline}

azure-pipelines · 2020-06-08T05:23:16Z

Azure Pipelines successfully started running 1 pipeline(s).

openapi-sdkautomation · 2020-06-08T05:25:12Z

Azure CLI Extension Generation - Release

Installation instruction for service desktopvirtualization [Preview Changes]
az extension add --source=https://sdkautomation.blob.core.windows.net/sdkautomation-pipeline/Azure/azure-rest-api-specs/9763/azure-cli-extensions/Azure/azure-cli-extensions/desktopvirtualization/desktopvirtualization-0.1.0-py3-none-any.whl

️✔️ succeeded [Logs] [Expand Details]

️✔️ Generate from 8a5a7c5 with merge commit 8e5820c. Azure CLI Automation 13.0.17.20200526.1

[AutoRest] 
[AutoRest] NO TEST SCENARIO PROVIDED - DEFAULT WILL BE USED
[AutoRest] ADD FOLLOWING SECTION TO readme.cli.md FILE TO MODIFY IT
[AutoRest] --------------------------------------------------------
[AutoRest]   test-scenario:
[AutoRest]     - name: /ApplicationGroups/put/ApplicationGroup_Create
[AutoRest]     - name: /ApplicationGroups/get/ApplicationGroup_Get
[AutoRest]     - name: /ApplicationGroups/get/ApplicationGroup_List
[AutoRest]     - name: /ApplicationGroups/get/ApplicationGroup_ListByResourceGroup
[AutoRest]     - name: /ApplicationGroups/patch/ApplicationGroups_Update
[AutoRest]     - name: /HostPools/put/HostPool_Create
[AutoRest]     - name: /HostPools/get/HostPool_Get
[AutoRest]     - name: /HostPools/get/HostPool_List
[AutoRest]     - name: /HostPools/get/HostPool_ListByResourceGroup
[AutoRest]     - name: /HostPools/patch/HostPool_Update
[AutoRest]     - name: /Workspaces/put/Workspace_Create
[AutoRest]     - name: /Workspaces/get/Workspace_Get
[AutoRest]     - name: /Workspaces/get/Workspace_ListByResourceGroup
[AutoRest]     - name: /Workspaces/get/Workspace_ListBySubscription
[AutoRest]     - name: /Workspaces/patch/Workspace_Update
[AutoRest]     - name: /ApplicationGroups/delete/ApplicationGroup_Delete
[AutoRest]     - name: /HostPools/delete/HostPool_Delete
[AutoRest]     - name: /Workspaces/delete/Workspace_Delete
[AutoRest] --------------------------------------------------------

️✔️desktopvirtualization [View full logs] [Release Azure CLI Changes]
- desktopvirtualization-0.1.0-py3-none-any.whl
- desktopvirtualization-0.1.0.zip
```
No run LangAfterScript
```

openapi-sdkautomation · 2020-06-08T05:25:13Z

azure-sdk-for-go - Release

️✔️ succeeded [Logs] [Expand Details]

️✔️ Generate from 8a5a7c5 with merge commit 8e5820c. SDK Automation 13.0.17.20200526.1
️✔️preview/desktopvirtualization/mgmt/2019-01-23-preview [View full logs] [Release SDK Changes]
- preview.desktopvirtualization.mgmt.2019-01-23-preview.zip
```
No run LangAfterScript
```
️✔️preview/desktopvirtualization/mgmt/2019-09-24-preview [View full logs] [Release SDK Changes]
- preview.desktopvirtualization.mgmt.2019-09-24-preview.zip
```
No run LangAfterScript
```
️✔️preview/desktopvirtualization/mgmt/2019-12-10-preview [View full logs] [Release SDK Changes]
- preview.desktopvirtualization.mgmt.2019-12-10-preview.zip
```
No run LangAfterScript
```

openapi-sdkautomation · 2020-06-08T05:25:19Z

azure-sdk-for-java - Release

️✔️ succeeded [Logs] [Expand Details]

️✔️ Generate from 8a5a7c5 with merge commit 8e5820c. SDK Automation 13.0.17.20200526.1
️✔️sdk/desktopvirtualization/mgmt-v2019_12_10_preview [View full logs] [Release SDK Changes]
```
No run LangAfterScript
```

openapi-sdkautomation · 2020-06-08T05:25:28Z

azure-sdk-for-js - Release

⚠️ warning [Logs] [Expand Details]

⚠️ Generate from 8a5a7c5 with merge commit 8e5820c. SDK Automation 13.0.17.20200526.1
```
Failed to find any diff after autorest so no changed packages was found.
```

openapi-sdkautomation · 2020-06-08T05:25:30Z

azure-sdk-for-python - Release

⚠️ warning [Logs] [Expand Details]

⚠️ Generate from 8a5a7c5 with merge commit 8e5820c. SDK Automation 13.0.17.20200526.1

⚠️azure-mgmt-desktopvirtualization [View full logs] [Release SDK Changes]

[build_conf] INFO:packaging_tools:Building template azure-mgmt-desktopvirtualization
[build_conf] INFO:packaging_tools.conf:Build default conf for azure-mgmt-desktopvirtualization
[build_conf] INFO:packaging_tools:Template done azure-mgmt-desktopvirtualization
[build_package] /usr/lib/python3.6/distutils/dist.py:261: UserWarning: Unknown distribution option: 'long_description_content_type'
[build_package]   warnings.warn(msg)
[build_package] warning: no files found matching '*.py' under directory 'tests'
[build_package] warning: no files found matching '*.yaml' under directory 'tests'
[build_package] /usr/lib/python3.6/distutils/dist.py:261: UserWarning: Unknown distribution option: 'long_description_content_type'
[build_package]   warnings.warn(msg)
[build_package] warning: no files found matching '*.py' under directory 'tests'
[build_package] warning: no files found matching '*.yaml' under directory 'tests'
[breaking_change_setup] Ignoring mock: markers 'python_version <= "2.7"' don't match your environment
Not exact 2 reports found:
Not generating changelog.
[ChangeLog] WARNING: Failed to generate ChangeLog.

openapi-sdkautomation · 2020-06-08T05:25:33Z

azure-sdk-for-python-track2 - Release

No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured

openapi-sdkautomation · 2020-06-08T05:25:51Z

azure-sdk-for-net - Release

No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured

openapi-sdkautomation · 2020-06-08T05:26:43Z

Trenton Generation - Release

No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured

azuresdkci · 2020-06-08T05:38:21Z

Can one of the admins verify this patch?

datr93 · 2020-06-08T16:41:19Z

lgtm

datr93 · 2020-06-08T16:42:09Z

@changlong-liu lgtm

changlong-liu · 2020-06-09T05:52:00Z

Thanks @datr93 ,

Hi @leni-msft , would you help help to merge this PR? Thanks.

leni-msft · 2020-06-09T06:48:28Z

@changlong-liu Adding additionalProperties is considered as breaking change. Could you clarify if it's not causing breaking change error for the existing rest-api consumers?

changlong-liu · 2020-06-09T06:52:04Z

Hi @leni-msft , I think desktopvirtualization has not been released in any SDK, so we can fix issues in it no matter whether it's breaking?

@datr93 for confirmation.

datr93 · 2020-06-09T16:33:50Z

yes no sdk shouldve been released
powershell has been released tho.

add tags type

8a5a7c5

changlong-liu requested a review from datr93 June 8, 2020 05:23

openapi-assignment-bot bot assigned leni-msft Jun 8, 2020

openapi-sdkautomation bot mentioned this pull request Jun 8, 2020

[AutoPR desktopvirtualization] add tags type AzureSDKAutomation/azure-cli-extensions#104

Closed

This was referenced Jun 8, 2020

[AutoPR azure-mgmt-desktopvirtualization] add tags type AzureSDKAutomation/azure-sdk-for-python#1377

Closed

[AutoPR sdk/desktopvirtualization/mgmt-v2019_12_10_preview] add tags type AzureSDKAutomation/azure-sdk-for-java#3291

Closed

openapi-assignment-bot bot added the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Jun 8, 2020

akning-ms removed the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Jun 9, 2020

akning-ms merged commit 8e5820c into Azure:master Jun 9, 2020

00Kai0 pushed a commit to 00Kai0/azure-rest-api-specs that referenced this pull request Oct 12, 2020

add tags type (Azure#9763)

e34e0ed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

add tags type #9763

add tags type #9763

changlong-liu commented Jun 8, 2020 •

edited by akning-ms

Loading

openapi-pipeline-app bot commented Jun 8, 2020 •

edited

Loading

azure-pipelines bot commented Jun 8, 2020

openapi-sdkautomation bot commented Jun 8, 2020 •

edited

Loading

openapi-sdkautomation bot commented Jun 8, 2020 •

edited

Loading

openapi-sdkautomation bot commented Jun 8, 2020 •

edited

Loading

openapi-sdkautomation bot commented Jun 8, 2020 •

edited

Loading

openapi-sdkautomation bot commented Jun 8, 2020 •

edited

Loading

openapi-sdkautomation bot commented Jun 8, 2020 •

edited

Loading

openapi-sdkautomation bot commented Jun 8, 2020 •

edited

Loading

openapi-sdkautomation bot commented Jun 8, 2020 •

edited

Loading

azuresdkci commented Jun 8, 2020

datr93 commented Jun 8, 2020

datr93 commented Jun 8, 2020

changlong-liu commented Jun 9, 2020

leni-msft commented Jun 9, 2020

changlong-liu commented Jun 9, 2020

datr93 commented Jun 9, 2020 •

edited

Loading

add tags type #9763

add tags type #9763

Conversation

changlong-liu commented Jun 8, 2020 • edited by akning-ms Loading

Contribution checklist:

ARM API Review Checklist

openapi-pipeline-app bot commented Jun 8, 2020 • edited Loading

[Staging] Swagger Validation Report

azure-pipelines bot commented Jun 8, 2020

openapi-sdkautomation bot commented Jun 8, 2020 • edited Loading

Azure CLI Extension Generation - Release

openapi-sdkautomation bot commented Jun 8, 2020 • edited Loading

azure-sdk-for-go - Release

openapi-sdkautomation bot commented Jun 8, 2020 • edited Loading

azure-sdk-for-java - Release

openapi-sdkautomation bot commented Jun 8, 2020 • edited Loading

azure-sdk-for-js - Release

openapi-sdkautomation bot commented Jun 8, 2020 • edited Loading

azure-sdk-for-python - Release

openapi-sdkautomation bot commented Jun 8, 2020 • edited Loading

azure-sdk-for-python-track2 - Release

openapi-sdkautomation bot commented Jun 8, 2020 • edited Loading

azure-sdk-for-net - Release

openapi-sdkautomation bot commented Jun 8, 2020 • edited Loading

Trenton Generation - Release

azuresdkci commented Jun 8, 2020

datr93 commented Jun 8, 2020

datr93 commented Jun 8, 2020

changlong-liu commented Jun 9, 2020

leni-msft commented Jun 9, 2020

changlong-liu commented Jun 9, 2020

datr93 commented Jun 9, 2020 • edited Loading

changlong-liu commented Jun 8, 2020 •

edited by akning-ms

Loading

openapi-pipeline-app bot commented Jun 8, 2020 •

edited

Loading

openapi-sdkautomation bot commented Jun 8, 2020 •

edited

Loading

openapi-sdkautomation bot commented Jun 8, 2020 •

edited

Loading

openapi-sdkautomation bot commented Jun 8, 2020 •

edited

Loading

openapi-sdkautomation bot commented Jun 8, 2020 •

edited

Loading

openapi-sdkautomation bot commented Jun 8, 2020 •

edited

Loading

openapi-sdkautomation bot commented Jun 8, 2020 •

edited

Loading

openapi-sdkautomation bot commented Jun 8, 2020 •

edited

Loading

openapi-sdkautomation bot commented Jun 8, 2020 •

edited

Loading

datr93 commented Jun 9, 2020 •

edited

Loading