Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove OPENSSL_VERSION_NUMBER version check for the CAPath option in libcurl #5009

Merged
merged 3 commits into from
Oct 5, 2023

Conversation

ahsonkhan
Copy link
Member

Following-up from #4982 (comment)

https://www.openssl.org/docs/manmaster/man3/OPENSSL_VERSION_NUMBER.html
https://en.wikipedia.org/wiki/OpenSSL#Major_version_releases

0x00905100L seems to correspond to 0.9.5 which is 20+ years old. We can assume the version of openssl is 1.1.1 or higher, since we don't support older versions anyway.

cc @phoebusm

Copy link
Member

@antkmsft antkmsft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but let's confirm with Larry in tomorrow's Standup.

sdk/core/azure-core/inc/azure/core/http/curl_transport.hpp Outdated Show resolved Hide resolved
@ahsonkhan ahsonkhan enabled auto-merge (squash) October 5, 2023 20:13
@ahsonkhan ahsonkhan merged commit 9a2c2e1 into Azure:main Oct 5, 2023
38 checks passed
@ahsonkhan ahsonkhan deleted the RemoveOpenSslCheck branch October 5, 2023 21:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants