Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Incapsulate all the defaults for options values such as authority host in a helper class and add authority host url validation. #5155

Merged
merged 3 commits into from
Nov 11, 2023
Merged

Incapsulate all the defaults for options values such as authority host in a helper class and add authority host url validation. #5155

merged 3 commits into from
Nov 11, 2023

Conversation

ahsonkhan
Copy link
Member

Fixes #5002
Fixes #4999

@ahsonkhan
Incapsulate all the defaults for options values such as authority host
3f96923 
in a helper class and add authority host url validation.
@ahsonkhan ahsonkhan self-assigned this Nov 11, 2023
@ahsonkhan
Copy link
Member Author

/azp run cpp - identity

@azure-pipelines Azure Pipelines
Copy link

Pull request contains merge conflicts.

@ahsonkhan
Copy link
Member Author

/azp run cpp - identity

@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@ahsonkhan ahsonkhan enabled auto-merge (squash) November 11, 2023 04:28
@ahsonkhan ahsonkhan merged commit f2bd227 into Azure:main Nov 11, 2023
81 checks passed
@ahsonkhan ahsonkhan deleted the DefaultOptionsAndValidate branch November 11, 2023 05:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@antkmsft antkmsft antkmsft approved these changes

@schaabs schaabs Awaiting requested review from schaabs schaabs is a code owner

@RickWinter RickWinter Awaiting requested review from RickWinter RickWinter is a code owner

@vhvb1989 vhvb1989 Awaiting requested review from vhvb1989

@gearama gearama Awaiting requested review from gearama gearama is a code owner

@LarryOsterman LarryOsterman Awaiting requested review from LarryOsterman LarryOsterman is a code owner

@pvaneck pvaneck Awaiting requested review from pvaneck pvaneck is a code owner automatically assigned from Azure/azure-sdk-write-identity

@billwert billwert Awaiting requested review from billwert billwert is a code owner automatically assigned from Azure/azure-sdk-write-identity

@KarishmaGhiya KarishmaGhiya Awaiting requested review from KarishmaGhiya KarishmaGhiya is a code owner automatically assigned from Azure/azure-sdk-write-identity

@scottaddie scottaddie Awaiting requested review from scottaddie scottaddie is a code owner automatically assigned from Azure/azure-sdk-write-identity

@chlowell chlowell Awaiting requested review from chlowell chlowell is a code owner automatically assigned from Azure/azure-sdk-write-identity

@mpodwysocki mpodwysocki Awaiting requested review from mpodwysocki mpodwysocki is a code owner automatically assigned from Azure/azure-sdk-write-identity

Assignees

@ahsonkhan ahsonkhan

Labels
Azure.Identity
Projects
Azure Identity SDK Improvements
Archived in project
Milestone
No milestone
2 participants
@ahsonkhan @antkmsft