-
Notifications
You must be signed in to change notification settings - Fork 128
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move tests to use azure pipeline credentials #5754
Changes from 48 commits
b5bb953
e4c3ea2
2c9810f
023df7b
2bd4ad2
e916110
c429beb
718edf4
6c1d77f
7bff790
47f4dbc
896bcaf
a096bc2
64aab50
7536282
70cc098
bd16918
8a2b5e7
8d07d30
14ea9cb
32a831f
40036c4
76745bb
757efd6
90504d5
95d26f4
1d6fa4c
a90e896
fb17a28
89d9bcf
03e5338
f1f7b82
5e686e2
a06f20c
737e344
5aa9d9a
a499b63
142ed8d
462c5bc
c4f6681
2509a54
2b31613
a78674d
2e2d86c
56dc0e8
80ed23c
13d3170
5d502b8
f717e6f
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -31,22 +31,22 @@ target_link_libraries(workload_identity_credential_sample PRIVATE azure-identity | |
target_include_directories(workload_identity_credential_sample PRIVATE .) | ||
create_per_service_target_build_for_sample(identity workload_identity_credential_sample) | ||
|
||
add_executable(client_secret_credential_sample client_secret_credential.cpp) | ||
target_link_libraries(client_secret_credential_sample PRIVATE azure-identity service get-env-helper) | ||
target_include_directories(client_secret_credential_sample PRIVATE .) | ||
create_per_service_target_build_for_sample(identity client_secret_credential_sample) | ||
|
||
add_executable(default_azure_credential_sample default_azure_credential.cpp) | ||
target_link_libraries(default_azure_credential_sample PRIVATE azure-identity service) | ||
target_include_directories(default_azure_credential_sample PRIVATE .) | ||
create_per_service_target_build_for_sample(identity default_azure_credential_sample) | ||
|
||
add_executable(environment_credential_sample environment_credential.cpp) | ||
target_link_libraries(environment_credential_sample PRIVATE azure-identity service) | ||
target_include_directories(environment_credential_sample PRIVATE .) | ||
create_per_service_target_build_for_sample(identity environment_credential_sample) | ||
|
||
add_executable(managed_identity_credential_sample managed_identity_credential.cpp) | ||
target_link_libraries(managed_identity_credential_sample PRIVATE azure-identity service) | ||
target_include_directories(managed_identity_credential_sample PRIVATE .) | ||
create_per_service_target_build_for_sample(identity managed_identity_credential_sample) | ||
#add_executable(client_secret_credential_sample client_secret_credential.cpp) | ||
gearama marked this conversation as resolved.
Show resolved
Hide resolved
gearama marked this conversation as resolved.
Show resolved
Hide resolved
|
||
#target_link_libraries(client_secret_credential_sample PRIVATE azure-identity service get-env-helper) | ||
#target_include_directories(client_secret_credential_sample PRIVATE .) | ||
#create_per_service_target_build_for_sample(identity client_secret_credential_sample) | ||
|
||
#add_executable(default_azure_credential_sample default_azure_credential.cpp) | ||
#target_link_libraries(default_azure_credential_sample PRIVATE azure-identity service) | ||
#target_include_directories(default_azure_credential_sample PRIVATE .) | ||
#create_per_service_target_build_for_sample(identity default_azure_credential_sample) | ||
Comment on lines
+39
to
+42
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Please explain why we are commenting all the samples out. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. identity samples that don't run due to creds issues in live There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I am not sure I understand the issue. It's reasonable for us to disable building/running the samples if we know the problem and have a plan to update it (even in a separate, follow-up PR). Can you share the error you were seeing or the link to the failing pipeline that required us to comment these out? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Looking at the pipelines that build and run Identity samples, they seem to pass from this PR, without commenting them out: |
||
|
||
#add_executable(environment_credential_sample environment_credential.cpp) | ||
#target_link_libraries(environment_credential_sample PRIVATE azure-identity service) | ||
#target_include_directories(environment_credential_sample PRIVATE .) | ||
#create_per_service_target_build_for_sample(identity environment_credential_sample) | ||
|
||
#add_executable(managed_identity_credential_sample managed_identity_credential.cpp) | ||
#target_link_libraries(managed_identity_credential_sample PRIVATE azure-identity service) | ||
#target_include_directories(managed_identity_credential_sample PRIVATE .) | ||
#create_per_service_target_build_for_sample(identity managed_identity_credential_sample) |
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -36,4 +36,3 @@ additional questions or comments. | |
[coc]: https://opensource.microsoft.com/codeofconduct/ | ||
[coc_faq]: https://opensource.microsoft.com/codeofconduct/faq/ | ||
[coc_contact]: mailto:[email protected] | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What's motivating this change to move this as an else?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the if statement is IF use AzrurePipelineCredentials define these ENVs , ti was upside down
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@weshaggard since Daniel is OOF, can you please help review the changes in this
live.tests.yml
file. I think it could benefit from an extra set of eyes to make sure it is as expected :)There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it was very easy to check , before my change the build the live tests were failing, after it was working
and if you read the line right above it you see the if statement
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks correct assuming you want to continue to run the samples via default credentials instead of with pipeline credentials.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Daniel was aware of the change, i talked to him before making it
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[7/3 10:01 AM] George Arama
from what i see in the live.tests.yml the
.....
-${{ else }}:
..
$env:AZURESUBSCRIPTION_CLIENT_ID = $account.Id
$env:AZURESUBSCRIPTION_TENANT_ID = $account.Tenants
...
the variables get defined when not using federated auth on the False branch
[7/3 10:24 AM] George Arama
in the live tests yaml the if/else branches for the run samples are flipped , i'm testing my fix for it
[7/3 11:13 AM] George Arama
looks like ti's working now as expected