Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[azeventhubs] Prefetch can't be configured with the Processor #19770

Closed
richardpark-msft opened this issue Jan 6, 2023 · 0 comments · Fixed by #19786
Closed

[azeventhubs] Prefetch can't be configured with the Processor #19770

richardpark-msft opened this issue Jan 6, 2023 · 0 comments · Fixed by #19786
Assignees
@richardpark-msft
Labels
Client This issue points to a problem in the data-plane of the library. Event Hubs

Comments

@richardpark-msft
Copy link
Member

We allow configuring Prefetch for PartitionClient instances created from ConsumerClient. We should add this option to the Processor as well since it creates PartitionClient instances on the user's behalf.
@richardpark-msft richardpark-msft added Event Hubs Client This issue points to a problem in the data-plane of the library. labels Jan 6, 2023
@richardpark-msft richardpark-msft self-assigned this Jan 6, 2023
@ghost ghost added the needs-triage Workflow: This is a new issue that needs to be triaged to the appropriate team. label Jan 6, 2023
@jhendrixMSFT jhendrixMSFT removed the needs-triage Workflow: This is a new issue that needs to be triaged to the appropriate team. label Jan 6, 2023
richardpark-msft pushed a commit to richardpark-msft/azure-sdk-for-go that referenced this issue Jan 11, 2023
- Added the option to configure prefetch count for ProcessorPartition…
d2646a2 
…Client's created from the Processor (Fixes Azure#19770)

- Fixed some issues with the stress tests. Batch tests were using a really large batch size, which was too large for the amount of memory we're using in our test containers.
- Processor tests weren't configuring a prefetch value (prior to this PR the setting wasn't exposed)

Also, just generally made the stress tests a bit cleaner, leveragin the scenario-matrix more for configuring values.
@richardpark-msft richardpark-msft mentioned this issue Jan 11, 2023
Merged
richardpark-msft added a commit that referenced this issue Jan 11, 2023
@richardpark-msft
[azeventhubs] Adding in prefetch value for the Processor, updating st…
4474d1e 
…ress tests (#19786)

- Added the option to configure prefetch count for ProcessorPartitionClient's created from the Processor
- Fixed some issues with the stress tests. Batch tests were using a really large batch size, which was too large for the amount of memory we're using in our test containers.
- Processor tests weren't configuring a prefetch value (prior to this PR the setting wasn't exposed)
    
Also, just generally made the stress tests a bit cleaner, leveragin the scenario-matrix more for configuring values.

Fixes #19770
@github-actions github-actions bot locked and limited conversation to collaborators Apr 11, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@richardpark-msft richardpark-msft

Labels
Client This issue points to a problem in the data-plane of the library. Event Hubs
Projects
None yet
Milestone
No milestone
2 participants
@jhendrixMSFT @richardpark-msft