Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

LRO poller rewrite #14752

Merged
merged 21 commits into from
Jun 11, 2021
Merged

LRO poller rewrite #14752

merged 21 commits into from
Jun 11, 2021

Commits on Jun 7, 2021

  1. LRO poller rewrite 

    Simplified implementation of LRO pollers for ARM.
Public surface area has been slightly changed, making it identical to
the data-plane implementation.
The different polling mechanisms have been split into internal packages,
with an exported LROPoller that implements the overall polling algorithm.
    @jhendrixMSFT
    jhendrixMSFT committed Jun 7, 2021
    Configuration menu
    Copy the full SHA
    f54f4fc View commit details
    Browse the repository at this point in the history

  2. Fix NopCloser package for earlier versions of Go

    @jhendrixMSFT
    jhendrixMSFT committed Jun 7, 2021
    Configuration menu
    Copy the full SHA
    a42cca6 View commit details
    Browse the repository at this point in the history

Commits on Jun 8, 2021

  1. handle empty response when a model is provided 

    log a message in this case
    @jhendrixMSFT
    jhendrixMSFT committed Jun 8, 2021
    Configuration menu
    Copy the full SHA
    5cca901 View commit details
    Browse the repository at this point in the history

  2. update location polling URL

    @jhendrixMSFT
    jhendrixMSFT committed Jun 8, 2021
    Configuration menu
    Copy the full SHA
    1de83a6 View commit details
    Browse the repository at this point in the history

  3. fix final GET for POST

    @jhendrixMSFT
    jhendrixMSFT committed Jun 8, 2021
    Configuration menu
    Copy the full SHA
    f0055bd View commit details
    Browse the repository at this point in the history

  4. handle absense of provisioning state for initial response body polling

    @jhendrixMSFT
    jhendrixMSFT committed Jun 8, 2021
    Configuration menu
    Copy the full SHA
    72a12ea View commit details
    Browse the repository at this point in the history

  5. verify polling URLs

    @jhendrixMSFT
    jhendrixMSFT committed Jun 8, 2021
    Configuration menu
    Copy the full SHA
    c23a499 View commit details
    Browse the repository at this point in the history

  6. move checking of errors to Poll method

    @jhendrixMSFT
    jhendrixMSFT committed Jun 8, 2021
    Configuration menu
    Copy the full SHA
    d62dc84 View commit details
    Browse the repository at this point in the history

Commits on Jun 9, 2021

  1. move logging of status to Poll()

    @jhendrixMSFT
    jhendrixMSFT committed Jun 9, 2021
    Configuration menu
    Copy the full SHA
    111758a View commit details
    Browse the repository at this point in the history

  2. export pipeline for pager-poller scenario

    @jhendrixMSFT
    jhendrixMSFT committed Jun 9, 2021
    Configuration menu
    Copy the full SHA
    b35dcff View commit details
    Browse the repository at this point in the history

  3. fail on a 202 DELETE/POST with no polling URL

    @jhendrixMSFT
    jhendrixMSFT committed Jun 9, 2021
    Configuration menu
    Copy the full SHA
    9eea802 View commit details
    Browse the repository at this point in the history

  4. differentiate between no response body and missing states 

    this is important for body polling which can tolerate a missing response
body for certain status codes.
    @jhendrixMSFT
    jhendrixMSFT committed Jun 9, 2021
    Configuration menu
    Copy the full SHA
    ab32e4c View commit details
    Browse the repository at this point in the history

  5. relax provisioning state requirement on initial async PUT response

    @jhendrixMSFT
    jhendrixMSFT committed Jun 9, 2021
    Configuration menu
    Copy the full SHA
    24e29f9 View commit details
    Browse the repository at this point in the history

  6. use provisioningState for loc polling when available

    @jhendrixMSFT
    jhendrixMSFT committed Jun 9, 2021
    Configuration menu
    Copy the full SHA
    216a0e5 View commit details
    Browse the repository at this point in the history

  7. fix up token decoding

    @jhendrixMSFT
    jhendrixMSFT committed Jun 9, 2021
    Configuration menu
    Copy the full SHA
    1c94713 View commit details
    Browse the repository at this point in the history

  8. consolidate status constants

    @jhendrixMSFT
    jhendrixMSFT committed Jun 9, 2021
    Configuration menu
    Copy the full SHA
    311af89 View commit details
    Browse the repository at this point in the history

  9. fix code comment

    @jhendrixMSFT
    jhendrixMSFT committed Jun 9, 2021
    Configuration menu
    Copy the full SHA
    7d4da50 View commit details
    Browse the repository at this point in the history

  10. fix closing of response body

    @jhendrixMSFT
    jhendrixMSFT committed Jun 9, 2021
    Configuration menu
    Copy the full SHA
    f38016c View commit details
    Browse the repository at this point in the history

Commits on Jun 10, 2021

  1. add comments to fields

    @jhendrixMSFT
    jhendrixMSFT committed Jun 10, 2021
    Configuration menu
    Copy the full SHA
    5578d4f View commit details
    Browse the repository at this point in the history

  2. simplify error handling for missing states

    @jhendrixMSFT
    jhendrixMSFT committed Jun 10, 2021
    Configuration menu
    Copy the full SHA
    a7ffaa0 View commit details
    Browse the repository at this point in the history

Commits on Jun 11, 2021

  1. add check for empty Location header

    @jhendrixMSFT
    jhendrixMSFT committed Jun 11, 2021
    Configuration menu
    Copy the full SHA
    b693086 View commit details
    Browse the repository at this point in the history