[Internal] fixing lint issues

sdk/internal/ci.yml

@@ -3,12 +3,14 @@ trigger:
   paths:
     include:
     - sdk/internal/
+    - eng/
 
 pr:
   paths:
     include:
     - sdk/internal/
-
+    - eng/
+
 stages:
 - template: ../../eng/pipelines/templates/jobs/archetype-sdk-client.yml
   parameters:

sdk/internal/mock/mock.go

@@ -151,7 +151,10 @@ func (s *Server) serveHTTP(w http.ResponseWriter, req *http.Request) {
 	if resp.delay > 0 {
 		time.Sleep(resp.delay)
 	}
-	resp.write(w)
+	err := resp.write(w)
+	if err != nil {
+		panic(err)
+	}
 }
 
 // Requests returns the number of times an HTTP request was made.
@@ -259,7 +262,7 @@ type mockResponse struct {
 	pred    ResponsePredicate
 }
 
-func (mr mockResponse) write(w http.ResponseWriter) {
+func (mr mockResponse) write(w http.ResponseWriter) error {
 	if len(mr.headers) > 0 {
 		for k, v := range mr.headers {
 			for _, vv := range v {
@@ -272,8 +275,12 @@ func (mr mockResponse) write(w http.ResponseWriter) {
 	}
 	w.WriteHeader(mr.code)
 	if mr.body != nil {
-		w.Write(mr.body)
+		_, err := w.Write(mr.body)
+		if err != nil {
+			return err
+		}
 	}
+	return nil
 }
 
 // WithStatusCode sets the HTTP response's status code to the specified value.

sdk/internal/mock/mock_test.go

@@ -305,7 +305,6 @@ func TestTLSServerConfig(t *testing.T) {
 func TestBodyReadError(t *testing.T) {
 	srv, close := NewServer()
 	defer close()
-	const body = "this is the response body"
 	srv.AppendResponse(WithBodyReadError())
 	req, err := http.NewRequest(http.MethodGet, srv.URL(), nil)
 	if err != nil {

sdk/internal/recording/recording.go

@@ -157,7 +157,10 @@ func (r *Recording) Do(req *http.Request) (*http.Response, error) {
 // Stop stops the recording and saves them, including any captured variables, to disk
 func (r *Recording) Stop() error {
 
-	r.recorder.Stop()
+	err := r.recorder.Stop()
+	if err != nil {
+		return err
+	}
 	if r.Mode == Live {
 		return nil
 	}
@@ -405,6 +408,9 @@ func (r *Recording) unmarshalVariablesFile(out interface{}) error {
 		}
 	} else {
 		err = yaml.Unmarshal(data, out)
+		if err != nil {
+			return err
+		}
 	}
 	return nil
 }