Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[azcore] updating doc.go #15477

Merged
merged 6 commits into from
Sep 7, 2021
Merged

[azcore] updating doc.go #15477

merged 6 commits into from
Sep 7, 2021

Conversation

seankane-msft
Copy link
Member

Updates doc.go with latest azcore updates.

  • The purpose of this PR is explained in this or a referenced issue.
  • The PR does not update generated files.
  • Tests are included and/or updated for code changes.
  • Updates to CHANGELOG.md are included.
  • MIT license headers are included in each file.

@seankane-msft seankane-msft self-assigned this Sep 3, 2021
@check-enforcer
Copy link

check-enforcer bot commented Sep 3, 2021

This repository is protected by Check Enforcer. The check-enforcer check-run will not pass until there is at least one more check-run successfully passing. Check Enforcer supports the following comment commands:

  • /check-enforcer evaluate; tells Check Enforcer to evaluate this pull request.
  • /check-enforcer override; by-pass Check Enforcer (approvals still required).

jhendrixMSFT
jhendrixMSFT reviewed Sep 3, 2021
View reviewed changes
sdk/azcore/doc.go Outdated Show resolved Hide resolved
jhendrixMSFT
jhendrixMSFT reviewed Sep 3, 2021
View reviewed changes
sdk/azcore/doc.go Outdated Show resolved Hide resolved
jhendrixMSFT
jhendrixMSFT previously approved these changes Sep 3, 2021
View reviewed changes
@jhendrixMSFT jhendrixMSFT dismissed their stale review September 3, 2021 21:11

want to make some more changes

@seankane-msft seankane-msft merged commit a8fe70b into Azure:main Sep 7, 2021
@seankane-msft seankane-msft deleted the azcore-docs branch September 7, 2021 17:17
jay-most pushed a commit to jay-most/azure-sdk-for-go that referenced this pull request Sep 18, 2021
@seankane-msft @jhendrixMSFT @vindicatesociety
[azcore] updating doc.go (Azure#15477)
16d48cd 
* updating doc.go

* update changelog

* joels comments

* fix up package names and examples

* add section on logging

* add doc.go for sub-packages

Co-authored-by: Joel Hendrix <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jhendrixMSFT jhendrixMSFT jhendrixMSFT approved these changes

@chlowell chlowell Awaiting requested review from chlowell chlowell is a code owner

@richardpark-msft richardpark-msft Awaiting requested review from richardpark-msft richardpark-msft is a code owner

@RickWinter RickWinter Awaiting requested review from RickWinter RickWinter is a code owner

Assignees

@seankane-msft seankane-msft

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@seankane-msft @jhendrixMSFT