Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add AzureCLICredentialOptions.TenantID #15761

Merged
merged 1 commit into from
Oct 23, 2021
Merged

Add AzureCLICredentialOptions.TenantID #15761

merged 1 commit into from
Oct 23, 2021

Conversation

chlowell
Copy link
Member

@chlowell chlowell commented Oct 8, 2021

Arch board feedback. Enables users to authenticate outside their home tenants when logged in to the CLI.

@chlowell chlowell added Client This issue points to a problem in the data-plane of the library. Azure.Identity labels Oct 8, 2021
jhendrixMSFT
jhendrixMSFT reviewed Oct 20, 2021
View reviewed changes
sdk/azidentity/README.md Outdated
@@ -280,7 +280,7 @@ or contact [[email protected]](mailto:[email protected]) with any
additional questions or comments.

[azure_cli]: https://docs.microsoft.com/cli/azure
[armresources_library]: https://github.com/Azure/azure-sdk-for-go/tree/main/sdk/resources/armresources
[armresources_library]: https://github.com/Azure/azure-sdk-for-go/blob/main/sdk/resourcemanager/resources/armresources
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My browser adjusted this to https://github.com/Azure/azure-sdk-for-go/tree/main/sdk/resourcemanager/resources/armresources

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mine as well, but the verification script performs some transformation on it and gets a broken URL. I'll remove this link for now and work with Ben to figure out what's going on with the script.

@check-enforcer
Copy link

This pull request is protected by Check Enforcer.

What is Check Enforcer?

Check Enforcer helps ensure all pull requests are covered by at least one check-run (typically an Azure Pipeline). When all check-runs associated with this pull request pass then Check Enforcer itself will pass.

Why am I getting this message?

You are getting this message because Check Enforcer did not detect any check-runs being associated with this pull request within five minutes. This may indicate that your pull request is not covered by any pipelines and so Check Enforcer is correctly blocking the pull request being merged.

What should I do now?

If the check-enforcer check-run is not passing and all other check-runs associated with this PR are passing (excluding license-cla) then you could try telling Check Enforcer to evaluate your pull request again. You can do this by adding a comment to this pull request as follows:
/check-enforcer evaluate
Typically evaulation only takes a few seconds. If you know that your pull request is not covered by a pipeline and this is expected you can override Check Enforcer using the following command:
/check-enforcer override
Note that using the override command triggers alerts so that follow-up investigations can occur (PRs still need to be approved as normal).

What if I am onboarding a new service?

Often, new services do not have validation pipelines associated with them. In order to bootstrap pipelines for a new service, please perform following steps:

For track 2 SDKs Issue the following command as a pull request comment:

/azp run prepare-pipelines
This will run a pipeline that analyzes the source tree and creates the pipelines necessary to build and validate your pull request. Once the pipeline has been created you can trigger the pipeline using the following comment:
/azp run go - [service] - ci

@chlowell
Copy link
Member Author

/azp run go - azidentity - ci

@azure-pipelines
Copy link

Azure Pipelines failed to run 1 pipeline(s).

@chlowell chlowell merged commit 6f3d959 into Azure:main Oct 23, 2021
@chlowell chlowell deleted the cli-tenant branch October 23, 2021 00:05
seankane-msft added a commit that referenced this pull request Oct 27, 2021
@seankane-msft @jhendrixMSFT
@chlowell @azure-sdk @benbp @jay-most @vindicatesociety @richardpark-msft @ealsur @Alancere @ArcturusZhang @chidozieononiwu
Azkeys Pull in latest main (#15961)
ef657fd 
* Add ARM-specific bearer token policy (#15885)

* Add ARM-specific bearer token policy

Removed support for auxiliary tenants from the runtime version of this
policy as this is specific to ARM.

* add tests for expiring resource

* remove superfluous x-ms-date header

* remove policy.TokenRequestOptions from AuthenticationOptions

* refactor bearer token policy constructors

* Update azservicebus test fake (#15735)

* Add release date for azcore v0.20.0 (#15915)

* Increment version for azcore releases (#15919)

Increment package version after release of azcore

* Fully automate cluster buildout. Add azure file share mount to stress tests. (#15918)

Co-authored-by: Ben Broderick Phillips <[email protected]>

* Fix azidentity CI (#15886)

* Add DefaultAzureCredential struct (#15759)

* Add AzureCLICredentialOptions.TenantID (#15761)

* Changed ThroughputOptions to use azcore Etag (#15900)

Co-authored-by: Jason Amos <[email protected]>

* [azservicebus] Cleanup/changes from API review (removal of processor and singular receives) (#15901)

API trimming/modifications based on review:

* Unexport Processor
* Unexport the singular message APIs (ReceiveMessage, ReceiveDeferredMessage) in favor of their plural counterparts.
* Deleting processor sample but would have anyways since we had an example file for it.
* Remove mentions of the Processor from our readme/migrationguide
* Remove mentions of the Processor in doc comments on exported types

* Clean up/organize script and json files in top level directory (#15453)

* Clean up/organize script and json files in top level directory

* Add eng/tools to coverage config and alphabetize it

* [Cosmos DB] [API Review] Move to azcore 0.20 and fit and finish (#15927)

* Port to azcore 0.20

* Item using byte array

* adding header policy tests

* more tests

* readme

* to int32

* lint

* Set floor of one second for polling delay (#15905)

To avoid excessive polling.
Add 429 to list of retriable HTTP status codes.

* Release sdk/resourcemanager/streamanalytics/armstreamanalytics v0.1.0 (#15840)

* [Release] sdk/resourcemanager/streamanalytics/armstreamanalytics/0.1.0 generation from spec commit: 3c16aae50c7110e1aad241ac93995621d4093d46

* fix

* Update CHANGELOG.md

* Update CHANGELOG.md

Co-authored-by: Arcturus <[email protected]>

* Release sdk/resourcemanager/databricks/armdatabricks v0.1.0 (#15842)

* [Release] sdk/resourcemanager/databricks/armdatabricks/0.1.0 generation from spec commit: 3c16aae50c7110e1aad241ac93995621d4093d46

* fix

* Update CHANGELOG.md

Co-authored-by: Dapeng Zhang <[email protected]>

* Release sdk/resourcemanager/scheduler/armscheduler v0.1.0 (#15843)

* [Release] sdk/resourcemanager/scheduler/armscheduler/0.1.0 generation from spec commit: 3c16aae50c7110e1aad241ac93995621d4093d46

* fix

* Update CHANGELOG.md

Co-authored-by: Dapeng Zhang <[email protected]>

* Release sdk/resourcemanager/notificationhubs/armnotificationhubs v0.1.0 (#15844)

* [Release] sdk/resourcemanager/notificationhubs/armnotificationhubs/0.1.0 generation from spec commit: 2a5304178ab7416e40622808dea5b630fb7854d9

* fix

* Update CHANGELOG.md

Co-authored-by: Dapeng Zhang <[email protected]>

* Release sdk/resourcemanager/search/armsearch v0.1.0 (#15846)

* [Release] sdk/resourcemanager/search/armsearch/0.1.0 generation from spec commit: 2a5304178ab7416e40622808dea5b630fb7854d9

* fix

* Update CHANGELOG.md

Co-authored-by: Dapeng Zhang <[email protected]>

* Release sdk/resourcemanager/alertsmanagement/armalertsmanagement v0.1.0 (#15847)

* Release sdk/resourcemanager/alertsmanagement/armalertsmanagement v0.1.0

* Update CHANGELOG.md

Co-authored-by: Dapeng Zhang <[email protected]>

* Release sdk/resourcemanager/mediaservices/armmediaservices v0.1.0 (#15866)

* [Release] sdk/resourcemanager/mediaservices/armmediaservices/0.1.0 generation from spec commit: c4d19b8362dfa8001c78062659ab88c529ece7b6

* fix

* Update CHANGELOG.md

Co-authored-by: Dapeng Zhang <[email protected]>

* Release sdk/resourcemanager/cognitiveservices/armcognitiveservices v0.1.0 (#15890)

* [Release] sdk/resourcemanager/cognitiveservices/armcognitiveservices/0.1.0 generation from spec commit: 762ca1046eedf2b2dba28784dd4aebffab2a9897

* fix

* Update CHANGELOG.md

Co-authored-by: Dapeng Zhang <[email protected]>

* Release sdk/resourcemanager/relay/armrelay v0.1.0 (#15892)

* [Release] sdk/resourcemanager/relay/armrelay/0.1.0 generation from spec commit: 769e09cac92c50b1f9fa6468775b7cb7de16bb06

* fix

* Update CHANGELOG.md

Co-authored-by: Dapeng Zhang <[email protected]>

* Release sdk/resourcemanager/managementgroups/armmanagementgroups v0.1.0 (#15909)

* [Release] sdk/resourcemanager/managementgroups/armmanagementgroups/0.1.0 generation from spec commit: 4aebac1bd77282ae8efe3dd2886e864537d31762

* fix

* Update CHANGELOG.md

Co-authored-by: Dapeng Zhang <[email protected]>

* Align azidentity environment variables with other SDKs (#15928)

* [Cosmos DB] Use time.Time to represent Timestamps/LastModified (#15939)

* manual serialization

* with pointer

* boolean signature

* Removing dead code

* Add latest released version to prepare prerelease (#15941)

Co-authored-by: Chidozie Ononiwu <[email protected]>

* Release sdk/resourcemanager/resourcehealth/armresourcehealth v0.1.0 (#15910)

* [Release] sdk/resourcemanager/resourcehealth/armresourcehealth/0.1.0 generation from spec commit: 4aebac1bd77282ae8efe3dd2886e864537d31762

* fix

* Update CHANGELOG.md

Co-authored-by: Dapeng Zhang <[email protected]>

* [azservicebus] Allow for renewing message and session locks (#15929)

Adding in message lock renewal and session lock renewal.

* Updating codeowners for Service Bus (#15943)

CODEOWNERS for Service Bus

* Remove old CI parameter (#15947)

* Release sdk/resourcemanager/datalake-analytics/armdatalakeanalytics v0.1.0 (#15938)

* [Release] sdk/resourcemanager/datalake-analytics/armdatalakeanalytics/0.1.0 generation from spec commit: 348665d474283df6a73d6a2ec6defef271251f13

* fix

* Update CHANGELOG.md

Co-authored-by: Dapeng Zhang <[email protected]>

* Increment version for resourcemanager/resourcehealth/armresourcehealth releases (#15952)

Increment package version after release of resourcemanager/resourcehealth/armresourcehealth

* Increment version for resourcemanager/managementgroups/armmanagementgroups releases (#15951)

Increment package version after release of resourcemanager/managementgroups/armmanagementgroups

* Increment version for resourcemanager/mediaservices/armmediaservices releases (#15949)

Increment package version after release of resourcemanager/mediaservices/armmediaservices

* Increment version for resourcemanager/relay/armrelay releases (#15948)

Increment package version after release of resourcemanager/relay/armrelay

* Increment version for resourcemanager/databricks/armdatabricks releases (#15933)

Increment package version after release of resourcemanager/databricks/armdatabricks

* Increment version for resourcemanager/streamanalytics/armstreamanalytics releases (#15932)

Increment package version after release of resourcemanager/streamanalytics/armstreamanalytics

* Increment version for resourcemanager/servicefabric/armservicefabric releases (#15873)

Increment package version after release of resourcemanager/servicefabric/armservicefabric

* Increment version for resourcemanager/mysql/armmysqlflexibleservers releases (#15868)

Increment package version after release of resourcemanager/mysql/armmysqlflexibleservers

* Increment version for resourcemanager/appplatform/armappplatform releases (#15860)

Increment package version after release of resourcemanager/appplatform/armappplatform

* update version number (#15850)

* Increment version for resourcemanager/datalake-analytics/armdatalakeanalytics releases (#15953)

Increment package version after release of resourcemanager/datalake-analytics/armdatalakeanalytics

* Increment package version after release of resourcemanager/cognitiveservices/armcognitiveservices (#15950)

* Increment package version after release of resourcemanager/notificationhubs/armnotificationhubs (#15937)

* Increment package version after release of resourcemanager/alertsmanagement/armalertsmanagement (#15936)

* Increment package version after release of resourcemanager/search/armsearch (#15935)

* Increment package version after release of resourcemanager/scheduler/armscheduler (#15934)

* Increment package version after release of resourcemanager/operationsmanagement/armoperationsmanagement (#15869)

* Increment package version after release of resourcemanager/mysql/armmysql (#15867)

* Increment package version after release of resourcemanager/recoveryservices/armrecoveryservices (#15861)

* Increment package version after release of resourcemanager/datalake-store/armdatalakestore (#15859)

* Increment version for resourcemanager/iothub/armiothub releases (#15832)

* Increment package version after release of resourcemanager/iothub/armiothub

* bump version

Co-authored-by: ArcturusZhang <[email protected]>

* Increment version for resourcemanager/security/armsecurity releases (#15827)

* Increment package version after release of resourcemanager/security/armsecurity

* bump version

Co-authored-by: ArcturusZhang <[email protected]>

* Revise azidentity errors (#15924)

* missing coverage for sb

Co-authored-by: Joel Hendrix <[email protected]>
Co-authored-by: Charles Lowell <[email protected]>
Co-authored-by: Azure SDK Bot <[email protected]>
Co-authored-by: Ben Broderick Phillips <[email protected]>
Co-authored-by: Jason <[email protected]>
Co-authored-by: Jason Amos <[email protected]>
Co-authored-by: Richard Park <[email protected]>
Co-authored-by: Matias Quaranta <[email protected]>
Co-authored-by: JiahuiPeng <[email protected]>
Co-authored-by: Arcturus <[email protected]>
Co-authored-by: Chidozie Ononiwu <[email protected]>
Co-authored-by: Dapeng Zhang <[email protected]>
jhendrixMSFT pushed a commit to jhendrixMSFT/azure-sdk-for-go that referenced this pull request Jan 12, 2022
@chlowell @jhendrixMSFT
Add AzureCLICredentialOptions.TenantID (Azure#15761)
29b8485
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jhendrixMSFT jhendrixMSFT jhendrixMSFT approved these changes

@RickWinter RickWinter Awaiting requested review from RickWinter RickWinter is a code owner

Assignees
No one assigned
Labels
Azure.Identity Client This issue points to a problem in the data-plane of the library.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@chlowell @jhendrixMSFT