Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[azidentity] Making ChainedTokenCredential re-use the first successful credential #16392

Merged
merged 24 commits into from
Jan 11, 2022
Merged

[azidentity] Making ChainedTokenCredential re-use the first successful credential #16392

merged 24 commits into from
Jan 11, 2022

Commits on Dec 2, 2021

  1. wip

    @sadasant
    sadasant authored Dec 2, 2021
    Configuration menu
    Copy the full SHA
    709222e View commit details
    Browse the repository at this point in the history

  2. tests passing

    @sadasant
    sadasant authored Dec 2, 2021
    Configuration menu
    Copy the full SHA
    fa5e663 View commit details
    Browse the repository at this point in the history

  3. last -> first

    @sadasant
    sadasant authored Dec 2, 2021
    Configuration menu
    Copy the full SHA
    0438cc4 View commit details
    Browse the repository at this point in the history

  4. no need for an explicit pointer for successfulCredential

    @sadasant
    sadasant authored Dec 2, 2021
    Configuration menu
    Copy the full SHA
    3f58cbc View commit details
    Browse the repository at this point in the history

  5. better reference to successfulCredential

    @sadasant
    sadasant authored Dec 2, 2021
    Configuration menu
    Copy the full SHA
    d5d1ea7 View commit details
    Browse the repository at this point in the history

  6. removed unnecessary else

    @sadasant
    sadasant authored Dec 2, 2021
    Configuration menu
    Copy the full SHA
    3715c8a View commit details
    Browse the repository at this point in the history

  7. moved formatError to be within the GetToken method

    @sadasant
    sadasant authored Dec 2, 2021
    Configuration menu
    Copy the full SHA
    f55385d View commit details
    Browse the repository at this point in the history

  8. Better tests 

    Now I'm testing that the right credential is the one that appears as
the successfulCredential, and that each credential is only called
as many times as expected.
    @sadasant
    sadasant authored Dec 2, 2021
    Configuration menu
    Copy the full SHA
    fa7d460 View commit details
    Browse the repository at this point in the history

  9. RetryAllSources and related documentation

    @sadasant
    sadasant authored Dec 2, 2021
    Configuration menu
    Copy the full SHA
    cf1ce47 View commit details
    Browse the repository at this point in the history

Commits on Dec 3, 2021

  1. updated the logic so that successfulCredential is always populated. I… 

    …mproved the tests
    @sadasant
    sadasant authored Dec 3, 2021
    Configuration menu
    Copy the full SHA
    a1bbdd1 View commit details
    Browse the repository at this point in the history

  2. Apply suggestions from code review

    @sadasant
    sadasant authored Dec 3, 2021
    Configuration menu
    Copy the full SHA
    dab4067 View commit details
    Browse the repository at this point in the history

Commits on Dec 9, 2021

  1. Merge remote-tracking branch 'Azure/main' into azidentity/fix16268

    @sadasant
    sadasant authored Dec 9, 2021
    Configuration menu
    Copy the full SHA
    2183d96 View commit details
    Browse the repository at this point in the history

  2. RetryAllSources to RetrySources

    @sadasant
    sadasant authored Dec 9, 2021
    Configuration menu
    Copy the full SHA
    e288440 View commit details
    Browse the repository at this point in the history

  3. Apply suggestions from code review 

    Co-authored-by: Charles Lowell <[email protected]>
    @sadasant @chlowell
    sadasant and chlowell authored Dec 9, 2021
    Configuration menu
    Copy the full SHA
    cdd4bb6 View commit details
    Browse the repository at this point in the history

  4. Feedback from Charles and adding RetrySources to the DefaultAzureCred… 

    …ential
    @sadasant
    sadasant authored Dec 9, 2021
    Configuration menu
    Copy the full SHA
    e2d1201 View commit details
    Browse the repository at this point in the history

Commits on Dec 10, 2021

  1. undoing changes to the DefaultAzureCredential

    @sadasant
    sadasant authored Dec 10, 2021
    Configuration menu
    Copy the full SHA
    8e51b2c View commit details
    Browse the repository at this point in the history

  2. simplified tests with new test credentials

    @sadasant
    sadasant authored Dec 10, 2021
    Configuration menu
    Copy the full SHA
    20197a9 View commit details
    Browse the repository at this point in the history

  3. Merge remote-tracking branch 'Azure/main' into azidentity/fix16268

    @sadasant
    sadasant authored Dec 10, 2021
    Configuration menu
    Copy the full SHA
    02bb755 View commit details
    Browse the repository at this point in the history

  4. removed the formatError function

    @sadasant
    sadasant authored Dec 10, 2021
    Configuration menu
    Copy the full SHA
    e14544a View commit details
    Browse the repository at this point in the history

  5. Avoiding testing that .successfulCredential is set

    @sadasant
    sadasant authored Dec 10, 2021
    Configuration menu
    Copy the full SHA
    a19c2f2 View commit details
    Browse the repository at this point in the history

Commits on Dec 13, 2021

  1. Apply suggestions from code review 

    Co-authored-by: Charles Lowell <[email protected]>
    @sadasant @chlowell
    sadasant and chlowell authored Dec 13, 2021
    Configuration menu
    Copy the full SHA
    af22a81 View commit details
    Browse the repository at this point in the history

  2. removed some redundant tests, the unavailableCredential, unexposed th… 

    …e testCredentialResponse and added a re-usable function to test a valid token response
    @sadasant
    sadasant authored Dec 13, 2021
    Configuration menu
    Copy the full SHA
    2080f96 View commit details
    Browse the repository at this point in the history

  3. formatting

    @sadasant
    sadasant authored Dec 13, 2021
    Configuration menu
    Copy the full SHA
    ae92c66 View commit details
    Browse the repository at this point in the history

Commits on Jan 11, 2022

  1. Update sdk/azidentity/chained_token_credential_test.go 

    Co-authored-by: Charles Lowell <[email protected]>
    @sadasant @chlowell
    sadasant and chlowell authored Jan 11, 2022
    Configuration menu
    Copy the full SHA
    0cac965 View commit details
    Browse the repository at this point in the history