Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Schedule jobs for creating release PR from mgmt. SDK release request #18635

Merged
merged 10 commits into from
Aug 2, 2022

Conversation

Alancere
Copy link
Member

No description provided.

@Alancere Alancere requested a review from tadelesh July 20, 2022 09:06
@Alancere Alancere linked an issue Jul 20, 2022 that may be closed by this pull request
@weshaggard
Copy link
Member

@Alancere @tadelesh
Can you give more details on this pipeline? I want to make sure I understand the goals of the auto-release and how it is expected to be triggered?

@tadelesh tadelesh changed the title Auto release pipeline Schedule jobs for creating release PR from mgmt. SDK release request Jul 21, 2022
@tadelesh
Copy link
Member

@weshaggard This pipeline aims to create release PR from the release request issue. It is a daily manual work for now and we want to use pipeline to schedule do it automatically. This approach is similar with Python's automation in use.

@Alancere Alancere marked this pull request as draft July 21, 2022 06:07
@weshaggard
Copy link
Member

Thanks for the context. @lirenhe how do you see this fitting in with our new sdk release powerapps flow? Do you see this still be a necessary step or would we attempt another release process?

@weshaggard
Copy link
Member

@dw511214992 should this process be handled by the SDK Automation instead of independent pipeline? It feels to me that we should be creating these release PR's automatically has spec changes get merged.

@tadelesh
Copy link
Member

@dw511214992 should this process be handled by the SDK Automation instead of independent pipeline? It feels to me that we should be creating these release PR's automatically has spec changes get merged.

Currently, we release our SDK only when there is release request. Spec change will be too frequent for SDK release. Is there any manually release trigger for the new powerapps workflow?

@dw511214992
Copy link
Member

I agree with @tadelesh . SDK automation pipeline cannot be used for release now because it's triggered by swagger PR. This PR is target at releasing go sdk by querying release request automatically.

When the powerapp is GA, I don't we need this pipeline. But for now, it's worth to create the pipeline as powerapp is not ready.

@weshaggard
Copy link
Member

Thanks for the extra context. I'm fine with using this as a release helper until we get a better E2E solution for releasing.

@Alancere Alancere marked this pull request as ready for review July 28, 2022 08:20
@Alancere
Copy link
Member Author

Alancere commented Aug 1, 2022

@tadelesh
Copy link
Member

tadelesh commented Aug 2, 2022

/check-enforcer evaluate

@tadelesh
Copy link
Member

tadelesh commented Aug 2, 2022

/check-enforcer override

1 similar comment
@tadelesh
Copy link
Member

tadelesh commented Aug 2, 2022

/check-enforcer override

@tadelesh tadelesh enabled auto-merge (squash) August 2, 2022 09:01
@tadelesh
Copy link
Member

tadelesh commented Aug 2, 2022

/check-enforcer override

@tadelesh tadelesh merged commit 24bcaf5 into Azure:main Aug 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Refine release tools to support create pr from release request
5 participants