Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Release] sdk/resourcemanager/compute/armcompute/4.0.0 #19244

Merged
merged 2 commits into from
Oct 8, 2022

Conversation

azure-sdk
Copy link
Collaborator

…m spec commit: 338ccc7bfc79689760959765543387e58b0e4855
@tadelesh
Copy link
Member

tadelesh commented Oct 4, 2022

@tadelesh
Copy link
Member

tadelesh commented Oct 4, 2022

@jhendrixMSFT @JeffreyRichter This release's breaking changes are from these three PRs and all have been approved: Azure/azure-rest-api-specs#20396, Azure/azure-rest-api-specs#20552, Azure/azure-rest-api-specs#19679. Regarding this release will raise armcompute version to v4, please help to review.

@jhendrixMSFT
Copy link
Member

I think the change made to the default version in Azure/azure-rest-api-specs#20396 was a mistake. Why would we set the default to an older version?

@tadelesh
Copy link
Member

tadelesh commented Oct 6, 2022

I think the change made to the default version in Azure/azure-rest-api-specs#20396 was a mistake. Why would we set the default to an older version?

The tag name looks old. But the swagger file version is new (gallery's swagger updated to 2022-03-03). compute RP is maintained by several teams, it seems they do not have a clear consolidated tag naming rule.

@jhendrixMSFT
Copy link
Member

I see, thanks for looking into it. Maybe we need some kind of linter rule for the default tag?

@tadelesh
Copy link
Member

tadelesh commented Oct 8, 2022

I see, thanks for looking into it. Maybe we need some kind of linter rule for the default tag?

Thanks for the suggestion. I'll raise the discussion with swagger team.

@Alancere Alancere merged commit c62af5d into main Oct 8, 2022
@Alancere Alancere deleted the release-compute-armcompute-4.0.0-1664586398 branch October 8, 2022 03:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants