CAE support for azidentity #19942
Merged
CAE support for azidentity #19942
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jhendrixMSFT
approved these changes
Feb 3, 2023
There was a problem hiding this comment.
I see a lot of WithXxx functions (Claims, SilentAccount, TenantID). We don't usually have this WithXxx pattern in Go (except maybe for Context). Do customers use this or is this internal implementation for us and it could be changed in a non-breaking way?
Do these WithXxx functions treat the input as immutable and return immutable results or modify the receiver of the WithXxx function? I'm OK with the former (what Context does) and not OK with the latter.
|
The With* functions are MSAL's options API. None is part of our public API. Are you still curious about their implementation?😆 |
|
No, not anymore. Thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the azidentity side of #14931. Credentials must do two things to enable the end-to-end feature: specify client capability "CP1" to indicate the client can handle claims challenges, and pass claims through
GetTokento MSAL. We send CP1 by default so applications are secure by default. Doing so has no effect when the RP doesn't support CAE or the tenant isn't configured for it. However, we provide an environment variable opt out for applications that can't handle claims challenges, for example because they need to upgrade a client library first.