Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[azquery] Release prep and final updates #19946

Merged
merged 9 commits into from
Feb 8, 2023
Merged

[azquery] Release prep and final updates #19946

merged 9 commits into from
Feb 8, 2023

Conversation

gracewilcox
Copy link
Member

  1. Preps for release
  2. README updates
  3. Makes LogsQueryOptions.String() private (request by Jeff)

@gracewilcox gracewilcox added Docs Client This issue points to a problem in the data-plane of the library. Monitor - Query labels Feb 4, 2023
chlowell
chlowell reviewed Feb 4, 2023
View reviewed changes
sdk/monitor/azquery/CHANGELOG.md Outdated Show resolved Hide resolved
sdk/monitor/azquery/custom_client.go Outdated Show resolved Hide resolved
sdk/monitor/azquery/README.md Show resolved Hide resolved
chlowell
chlowell approved these changes Feb 7, 2023
View reviewed changes
sdk/monitor/azquery/example_test.go Outdated Show resolved Hide resolved
@scottaddie
Copy link
Member

scottaddie commented Feb 7, 2023 •
edited
Loading

@gracewilcox Please also ensure the troubleshooting guide reflects current state. I quickly scanned it and noticed this code sample is no longer valid for setting the wait time: https://github.com/Azure/azure-sdk-for-go/blob/main/sdk/monitor/azquery/TROUBLESHOOTING.md#troubleshooting-server-timeouts-when-executing-logs-query-request

@gracewilcox
Copy link
Member Author

Troubleshooting guide updated in 98fe388

scottaddie
scottaddie approved these changes Feb 7, 2023
View reviewed changes
Copy link
Member

@scottaddie scottaddie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit: Nice work bringing this release to the finish line!

@gracewilcox gracewilcox merged commit b9cc6e5 into Azure:main Feb 8, 2023
@scottaddie scottaddie added Monitor Monitor, Monitor Ingestion, Monitor Query and removed Monitor - Query labels Sep 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chlowell chlowell chlowell approved these changes

@scottaddie scottaddie scottaddie approved these changes

@jhendrixMSFT jhendrixMSFT Awaiting requested review from jhendrixMSFT jhendrixMSFT is a code owner

Assignees
No one assigned
Labels
Client This issue points to a problem in the data-plane of the library. Docs Monitor Monitor, Monitor Ingestion, Monitor Query
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@gracewilcox @scottaddie @chlowell