More Service Client and Queue Client Tests #19958
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
tasherif-msft
changed the title
tasherif-msft
requested review from
siminsavani-msft,
souravgupta-msft,
jhendrixMSFT and
gapra-msft
as code owners
| @@ -369,10 +387,13 @@ type UpdateMessageOptions struct { | |||
| } | |||
|
|
|||
| func (o *UpdateMessageOptions) format() *generated.MessageIDClientUpdateOptions { | |||
| defaultVT := to.Ptr(int32(0)) | |||
There was a problem hiding this comment.
setting it to just 'nil' won't work?
vibhansa-msft
approved these changes
Feb 10, 2023
jhendrixMSFT
added a commit
that referenced
this pull request
Feb 15, 2023
* Generate Code for AzQueue (#19729) * first generation * removed queuename from url param * fixed georep * removed pagination * move to internal * last generation * [Feature] Queue Service Client + Key Credential Authentication (#19732) * first generation * removed queuename from url param * fixed georep * removed pagination * added basic methods * added basic models * regenrated and added pager * regenrated and added pager * autorest comment change * comments * comments * comments * version change * marker * rename to queue * further cleanup * rename service client * add license * Enable CI for azqueue (#19835) * Update to latest code generator for azqueue (#19837) * Update to latest code generator for azqueue Add build.go and format generated code. * add changelog * [Feature] SAS Support + Test Framework (#19756) * first generation * removed queuename from url param * fixed georep * removed pagination * added basic methods * added basic models * regenrated and added pager * regenrated and added pager * autorest comment change * comments * comments * comments * added sas perms and basic tests * spell check * cleanup * version change * added sas method for service client * uncomment test * cleanup * cleanup * sas test * cleanup * new test framework * update internal module to support test assets * set code coverage floor * fixed linter Co-authored-by: Joel Hendrix <[email protected]> * Queue Client + More Tests (#19852) * added basic queue client * added create and delete queue * added tests to service client for queues * added test to ensure pagination behaves correctly * updated tests * added TODOs * more tests * assets * lint * added more queue methods * more methods * added tests * export * export * export * added more tests * cleanup * address comments * removed message id from composite * removed account services and cleaned up * renamed cors * renamed cors * fixed cors test failure * lint * Queues Live Pipeline + APIViews Feedback (#19955) * removed item suffix * test resources file * lint fix * renamed queues list * fix * More Service Client and Queue Client Tests (#19958) * removed item suffix * test resources file * lint fix * added more service client tests * added more service client tests * fix tests * fix tests * added more message related tests * added peek message tests * cleaup * added tests for clear and delete * added update tests * more code coverage * cleanup * added stats test * added one more test * removed test * added client tests * more sas tests * more tests * AzQueue Public Preview APIVIew Feedback (#20003) * Resolve APIView feedback for Public Preview * test * More api view comments * expose GRS * constants * tests * cleanup * Changelog Entry + doc.go File + Basic Samples (#20004) * added basic doc * added a doc.go file * sample todos * added readme file * readme update * cleanup * cleanup * added samples * go update * go update * link fix --------- Co-authored-by: Joel Hendrix <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added: