Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix wrong order of require.Equal arguments #19977

Merged
merged 2 commits into from
Feb 9, 2023
Merged

fix wrong order of require.Equal arguments #19977

merged 2 commits into from
Feb 9, 2023

Conversation

tadelesh
Copy link
Member

@tadelesh tadelesh commented Feb 8, 2023

  • The purpose of this PR is explained in this or a referenced issue.
  • The PR does not update generated files.
  • Tests are included and/or updated for code changes.
  • Updates to CHANGELOG.md are included.
  • MIT license headers are included in each file.

chlowell
chlowell approved these changes Feb 8, 2023
View reviewed changes
sdk/containers/azcontainerregistry/client_test.go Outdated Show resolved Hide resolved
sdk/containers/azcontainerregistry/client_test.go Outdated Show resolved Hide resolved
sdk/containers/azcontainerregistry/client_test.go Outdated Show resolved Hide resolved
sdk/containers/azcontainerregistry/client_test.go Outdated Show resolved Hide resolved
sdk/containers/azcontainerregistry/client_test.go Outdated Show resolved Hide resolved
sdk/containers/azcontainerregistry/client_test.go Outdated Show resolved Hide resolved
sdk/resourcemanager/internal/testutil/helper_test.go Outdated Show resolved Hide resolved
RickWinter
RickWinter approved these changes Feb 9, 2023
View reviewed changes
Copy link
Member

@RickWinter RickWinter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agree with using require.True and require.False in the places Charles mentioned.

@tadelesh tadelesh enabled auto-merge (squash) February 9, 2023 02:16
@tadelesh tadelesh merged commit 1155bce into Azure:main Feb 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RickWinter RickWinter RickWinter approved these changes

@chlowell chlowell chlowell approved these changes

@ArcturusZhang ArcturusZhang Awaiting requested review from ArcturusZhang ArcturusZhang is a code owner

@lirenhe lirenhe Awaiting requested review from lirenhe lirenhe is a code owner

@richardpark-msft richardpark-msft Awaiting requested review from richardpark-msft richardpark-msft is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tadelesh @RickWinter @chlowell