azcontainerregistry: delegate token caching #23272
Conversation
stevekuznetsov
requested review from
RickWinter,
chlowell and
richardpark-msft
as code owners
github-actions
bot
added
Community Contribution
|
Thank you for your contribution @stevekuznetsov! We will review the pull request and get back to you soon. |
stevekuznetsov
force-pushed
the
skuznets/authentication-token-cache
branch
from
9353201
to
86a8f8d
Compare
|
I don't see anything wrong with this, however I also don't see a reason to make these changes, because they don't affect client behavior or the module's public API. Can you please describe the scenario motivating this? I take it you want to replace the ACR token cache of a |
|
@chlowell were you aware of the conversation happening on #20571? Sorry if I was not clear - I 100% agree with you that the changes here as they are will not be user-visible, but their value comes from the context of that issue, specifically what I laid out in this comment. |
I would like to propose a generally-useful token cache in a future commit. Managing the refresh tokens and exchanging them for access tokens does not need to rely specifically on the authentication policy or the specific client request being made, so this commit decouples the two concerns, thereby enabling the future refactor to be simpler. Signed-off-by: Steve Kuznetsov <[email protected]>
Mechanically refactor token caching, retrieval and exchange behavior from the authentication policy into a dedicated object, allowing us to separate token management concerns from Azure client policy concerns. Signed-off-by: Steve Kuznetsov <[email protected]>
This commit simply moves code from one location to another, broken out from other commits for ease of review. Signed-off-by: Steve Kuznetsov <[email protected]>
stevekuznetsov
force-pushed
the
skuznets/authentication-token-cache
branch
from
86a8f8d
to
308795f
Compare
|
Rebased after pre-requisite PR merged. |
|
Hi @stevekuznetsov. Thank you for your interest in helping to improve the Azure SDK experience and for your contribution. We've noticed that there hasn't been recent engagement on this pull request. If this is still an active work stream, please let us know by pushing some changes or leaving a comment. Otherwise, we'll close this out in 7 days. |
github-actions
bot
added
the
no-recent-activity
|
Would be great to do it but not sure if maintainers want this feature. |
github-actions
bot
removed
the
no-recent-activity
azcontainerregistry: decouple token exchange from request specifics
I would like to propose a generally-useful token cache in a future
commit. Managing the refresh tokens and exchanging them for access
tokens does not need to rely specifically on the authentication policy
or the specific client request being made, so this commit decouples the
two concerns, thereby enabling the future refactor to be simpler.
Signed-off-by: Steve Kuznetsov [email protected]
azcontainerregistry: delegate token caching
Mechanically refactor token caching, retrieval and exchange behavior
from the authentication policy into a dedicated object, allowing us to
separate token management concerns from Azure client policy concerns.
Signed-off-by: Steve Kuznetsov [email protected]
azcontainerregistry: move code
This commit simply moves code from one location to another, broken out
from other commits for ease of review.
Signed-off-by: Steve Kuznetsov [email protected]
Builds on top of #23270
Proving out a separation of concerns that could solve #20571