[azadmin] change frequency of poller in tests #23475
Open
+40
−7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gracewilcox
added
KeyVault
Client
chlowell
reviewed
Sep 20, 2024
chlowell
approved these changes
Sep 21, 2024
| testSerde(t, &sasToken) | ||
|
|
||
| // if in live mode, wait 30 seconds before polling again |
There was a problem hiding this comment.
Personally I think this code is too clear for a comment, but if you want something here, replace the "30 seconds" stuff with something about "default frequency"
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Modifying the poller so that it polls every second instead of every 30 seconds in playback mode. Now in playback mode it'll take the tests 2 seconds to complete instead of 67.