Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding Multi-API Version support packages. #812

Merged
merged 12 commits into from
Oct 16, 2017
Merged

Adding Multi-API Version support packages. #812

merged 12 commits into from
Oct 16, 2017

Conversation

marstr
Copy link
Member

@marstr marstr commented Oct 13, 2017

This is a set of packages generated by the most recent generator.exe which have explicit support for every API Version that a Service supports.

Currently there are a few notable missing packages, but they will all be added in before these changes hit master:
edit: At this point, recovery services and all of its children are the only ones that we ship today that aren't present in this PR.

  • azsadmin
  • batchai
  • cognitive services data-plane packages
  • machine learning compute
  • marketplace ordering edit: added in ff8c2c2
  • operations management edit: added in c80ca3a
  • recovery services
  • recovery services backup
  • recovery services site recovery
  • resource health edit: this was added in 14f105a
  • resources edit: this was added in a5ce301
  • service map edit: this was added in e8dd531
  • sql edit: this was added in c394fb4
  • traffic manager edit: this was added in c2dc1c4
  • web edit: this was added in 5f51c6a

A few packages broke our generator, and I've manually deleted them. Those are:

  • compute 2015-06-15
  • network 2015-05-01-preview
  • network 2015-06-15

These packages are a direct result of the changes seen in Azure/azure-rest-api-specs#1787

@marstr
Copy link
Member Author

marstr commented Oct 13, 2017

To review, I'd recommend a git checkout out on my fork's dev branch and playing with it.

@mcardosos
Copy link
Contributor

cosmos-db has package documentdb inside, is that intentional?

@mcardosos
Copy link
Contributor

Another question, this would not replace the arm folder? For breaking changes reasons

@mcardosos
Copy link
Contributor

Datalake Analytics management package is missing.

@mcardosos
Copy link
Contributor

Not a big fan of machine_learning folder having an underscore

@mcardosos
Copy link
Contributor

Question, are you planning to generate a latest profile that works the same as our current arm folder?

@mcardosos
Copy link
Contributor

billing is missing the mgmt folder

@mcardosos
Copy link
Contributor

There are some dataplane SDKs that we are not generatin right now, monitor, search, servicefabric

@marstr
Copy link
Member Author

marstr commented Oct 13, 2017

@mcardosos says:
cosmos-db has package documentdb inside, is that intentional?

Yep! I was just trying to match their Swagger declarations found here: Azure/azure-rest-api-specs/specification/cosmos-db/resource-manager/Microsoft.DocumentDB

@marstr
Copy link
Member Author

marstr commented Oct 13, 2017

@mcardosos says:
Another question, this would not replace the arm folder? For breaking changes reasons

Correct, today it would not replace it, and we'd release that as v11.2.0-beta but starting in v12 we'd mark everything in the arm directory as deprecated.

@marstr
Copy link
Member Author

marstr commented Oct 13, 2017

@mcardosos says
Question, are you planning to generate a latest profile that works the same as our current arm folder?

Yes, at least in some capacity. However, I'm going to be sending a separe profile PR after this one is merged into dev.

@marstr
Copy link
Member Author

marstr commented Oct 13, 2017

@mcardosos says:
There are some dataplane SDKs that we are not generatin right now, monitor, search, servicefabric

🤐 This was deliberate on my part.

@marstr
Copy link
Member Author

marstr commented Oct 13, 2017

@mcardosos says:
Not a big fan of machine_learning folder having an underscore

I'll take it out then. No biggie.

@marstr marstr merged commit 2e898b2 into Azure:dev Oct 16, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants