Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use RequestOptions error configuration on OpenTelemetry plugin #25157

Closed
lmolkova opened this issue Nov 2, 2021 · 1 comment
Closed

Use RequestOptions error configuration on OpenTelemetry plugin #25157

lmolkova opened this issue Nov 2, 2021 · 1 comment
Assignees
@lmolkova
Labels
Client This issue points to a problem in the data-plane of the library. OpenTelemetry OpenTelemetry instrumentation

Comments

@lmolkova
Copy link
Member

lmolkova commented Nov 2, 2021

Related to #25130. No-throw option indicates span status should not be set to ERROR - this addresses user feedback mostly around 404/409 and make tracing consistent with .NET
@ghost ghost added the needs-triage Workflow: This is a new issue that needs to be triaged to the appropriate team. label Nov 2, 2021
@lmolkova lmolkova self-assigned this Nov 2, 2021
@lmolkova lmolkova added Client This issue points to a problem in the data-plane of the library. OpenTelemetry OpenTelemetry instrumentation labels Nov 2, 2021
@ghost ghost removed the needs-triage Workflow: This is a new issue that needs to be triaged to the appropriate team. label Nov 2, 2021
@lmolkova lmolkova mentioned this issue Nov 12, 2021
Merged
azure-sdk pushed a commit to azure-sdk/azure-sdk-for-java that referenced this issue Nov 10, 2023
@alexkarcher-msft @dannysongg
@vishal1997 @crosenblatt @sushmithavangala @rohinisharma @mukundnigam @kamperiadis @ha0ch1
CodeGen from PR 26545 in Azure/azure-rest-api-specs
00b69fe 
Release web 2023 01 01 (Azure#26545)

* Add new api-version 2023-01-01 (Azure#22962)

* Add new api-version 2023-01-01

* Change default package api-version

* Updated workflowstate to be a reference (Azure#23084)

* Fix OneDeploy request and response bodies (Azure#23224)

* Fix OneDeploy request and response bodies

* Fixing typo

* Add Container Apps Environment Id in checknameavailability API (Azure#24102)

Co-authored-by: Vishal Gupta <[email protected]>

* Add minTlsCipherSuite property (Azure#24198)

* Add minTlsCipherSuite property

* Move to SiteConfig

---------

Co-authored-by: Chris Rosenblatt <[email protected]>

* Dapr configuration for a site (Azure#24606)

* Dapr configuration for a site

* removed dapr older definition

* adding back old dapr definition

* Modified 'Dapr' to 'DaprConfig' to resolve conflicts with older dapr definition

* to initiate checks as re-run

* fixed prettier check fail

---------

Co-authored-by: Sushmitha Vangala <[email protected]>

* Fix for JS SDK check failure for Dapr Config (Azure#25493)

* Dapr configuration for a site

* removed dapr older definition

* adding back old dapr definition

* Modified 'Dapr' to 'DaprConfig' to resolve conflicts with older dapr definition

* to initiate checks as re-run

* fixed prettier check fail

* JS Sdk check fail fix

---------

Co-authored-by: Sushmitha Vangala <[email protected]>

* Release web 2023 01 01 (Azure#25157)

* Adding locations/usages endpoint and example

* Revert "Adding locations/usages endpoint and example"

This reverts commit 4a1110765d08c5c96d65f884237313515d842586.

* Adding back usages changes with up to date branch

* Updates based on verification tools

* Fixing spacing, adding missing comma

* ran prettier-fix for formatting

* Update for new QMS requirements with ZR

* Using prettier to fix linter error

* Adding ZR endpoint

* Fixing duplicate operationId

* QMS Usages

* Validation changes

* Updating schema

* Updating for collection

* fixing pr comments

* Resolving comments

* Updating description

* Resolving comments

---------

Co-authored-by: Rohini Sharma <[email protected]>

* Release web 2023 01 01 (Azure#25629)

* Adding locations/usages endpoint and example

* Revert "Adding locations/usages endpoint and example"

This reverts commit 4a1110765d08c5c96d65f884237313515d842586.

* Adding back usages changes with up to date branch

* Updates based on verification tools

* Fixing spacing, adding missing comma

* ran prettier-fix for formatting

* Update for new QMS requirements with ZR

* Using prettier to fix linter error

* Adding ZR endpoint

* Fixing duplicate operationId

* QMS Usages

* Validation changes

* Updating schema

* Updating for collection

* fixing pr comments

* Resolving comments

* Updating description

* Resolving comments

* Removing quota type parameter

---------

Co-authored-by: Rohini Sharma <[email protected]>

* Adding workload profile & resource config to Site (Azure#25868)

* Adding workload profile & resource config to Site

* prettier fix

* cosmetic fix

* updating examples

* prettier fix

* Fix Python SDK failure for Dapr log level config (Azure#26198)

* Rename log level enum for dapr

* Fix Python SDK failure for Dapr log level config

* Rename log level num for dapr (Azure#26374)

* Rename log level num for dapr

* Rename log level num for dapr

* initial change to add ase regions (Azure#26333)

* initial change to add ase regions

* addressing comments

* nit adding example as suggested

* formatting code

* add custom word

* prettier everything

* prettier everything

* Revert "Fix OneDeploy request and response bodies (Azure#23224)" (Azure#26580)

This reverts commit 7dfc303ee18440ee5eede155bb0d63797fbdc4bb.

---------

Co-authored-by: Alex Karcher <[email protected]>
Co-authored-by: dannysongg <[email protected]>
Co-authored-by: Vishal Gupta <[email protected]>
Co-authored-by: Vishal Gupta <[email protected]>
Co-authored-by: Chris Rosenblatt <[email protected]>
Co-authored-by: Chris Rosenblatt <[email protected]>
Co-authored-by: SushmithaVReddy <[email protected]>
Co-authored-by: Sushmitha Vangala <[email protected]>
Co-authored-by: rohinisharma <[email protected]>
Co-authored-by: Rohini Sharma <[email protected]>
Co-authored-by: mukundnigam <[email protected]>
Co-authored-by: Kirstyn Amperiadis <[email protected]>
Co-authored-by: Haochi <[email protected]>
@github-actions GitHub Actions
Copy link

Hi @lmolkova, we deeply appreciate your input into this project. Regrettably, this issue has remained inactive for over 2 years, leading us to the decision to close it. We've implemented this policy to maintain the relevance of our issue queue and facilitate easier navigation for new contributors. If you still believe this topic requires attention, please feel free to create a new issue, referencing this one. Thank you for your understanding and ongoing support.

@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Mar 13, 2024
@github-actions github-actions bot locked and limited conversation to collaborators Mar 13, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@lmolkova lmolkova

Labels
Client This issue points to a problem in the data-plane of the library. OpenTelemetry OpenTelemetry instrumentation
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@lmolkova