Supporting sparse the test parameters #10312
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sima-zhu
requested review from
danieljurek,
JimSuplizio,
mitchdenny and
weshaggard
as code owners
|
/azp run java - keyvault - tests |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run java - search - tests |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run java - keyvault - tests |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run java - search- tests |
|
No pipelines are associated with this pull request. |
|
/azp run java - appconfiguration - tests |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run java - search - tests |
|
Azure Pipelines successfully started running 1 pipeline(s). |
srnagar
approved these changes
Apr 17, 2020
Comment on lines
624
to
625
| System.out.println(httpClient); | ||
| System.out.println(serviceVersion); |
There was a problem hiding this comment.
Suggested change
| System.out.println(httpClient); | |
| System.out.println(serviceVersion); | |
| System.out.printf("HttpClient is %s; Service Version is %s", httpClient, serviceVersion); |
JimSuplizio
approved these changes
Apr 17, 2020
sima-zhu
requested review from
alzimmermsft,
amishra-dev and
anuchandy
as code owners
sima-zhu
requested review from
conniey,
David-Noble-at-work,
gapra-msft,
hemanttanwar,
jaschrep-msft,
jianghaolu,
JonathanGiles,
joshfree,
kirankumarkolli,
kushagraThapar,
mbhaskar,
moderakh,
mssfang,
nemakam,
rickle-msft and
yvgopal
as code owners
|
/azp run java - keyvault - tests |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
Right now, it is able to display the right name from Test tab. |
| <artifactId>maven-surefire-plugin</artifactId> | ||
| <version>3.0.0-M4</version> <!-- {x-version-update;org.apache.maven.plugins:maven-surefire-plugin;external_dependency} --> | ||
| <configuration> | ||
| <rerunFailingTestsCount>3</rerunFailingTestsCount> |
There was a problem hiding this comment.
Generally we don't want to be retrying failing tests as this could mask flakiness in our clients.
There was a problem hiding this comment.
Right, will remove.
srnagar
approved these changes
Apr 17, 2020
alzimmermsft
approved these changes
Apr 17, 2020
weshaggard
reviewed
Apr 17, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The PR is to sparse the httpclient to matrix.
Test over four scenarios: