Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#1078] Add async delete support #1102

Merged
merged 2 commits into from
Sep 26, 2016
Merged

Conversation

jianghaolu
Copy link
Contributor

@jianghaolu jianghaolu commented Sep 23, 2016

@azuresdkci
Copy link
Contributor

Runtime changes detected. pull request created. CI running: Build Status

Copy link
Member

@anuchandy anuchandy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.. left one comment, pls take a look

}
}), callback);
}

Copy link
Member

@anuchandy anuchandy Sep 24, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

 @Override
 public abstract Observable<Void> deleteAsync(string id);

is it cleaner if we add this here?

@Override
public Observable<Void> deleteAsync(String id) {
return deleteAsync(ResourceUtils.groupFromResourceId(id), ResourceUtils.nameFromResourceId(id));
}
Copy link
Member

@anuchandy anuchandy Sep 24, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same as previous comment..

 @Override
 public abstract Observable<Void> deleteAsync(string groupName, string name);

@martinsawicki martinsawicki merged commit 09ded68 into Azure:master Sep 26, 2016
jianghaolu pushed a commit to jianghaolu/azure-sdk-for-java that referenced this pull request Feb 27, 2017
per Anu's review, ok to merge -- comments could be addressed separately and are not blocking
jianghaolu pushed a commit to jianghaolu/azure-sdk-for-java that referenced this pull request Feb 27, 2017
per Anu's review, ok to merge -- comments could be addressed separately and are not blocking
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants