-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make data required for EventGridEvent #15000
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Data is now a parameter in the constructor, and does not have a setter method
Soreloser2
added
Event Grid
Client
This issue points to a problem in the data-plane of the library.
labels
Sep 9, 2020
Soreloser2
requested review from
anuchandy,
conniey,
hemanttanwar,
jianghaolu,
JonathanGiles,
joshfree and
srnagar
as code owners
September 9, 2020 23:17
joshfree
approved these changes
Sep 9, 2020
11 tasks
openapi-sdkautomation bot
pushed a commit
to AzureSDKAutomation/azure-sdk-for-java
that referenced
this pull request
Jun 28, 2021
alertsmanagement,applicationinsights,attestation,batch,cost-management,netapp,synapse (Azure#15000)
openapi-sdkautomation bot
pushed a commit
to AzureSDKAutomation/azure-sdk-for-java
that referenced
this pull request
Jun 28, 2021
alertsmanagement,applicationinsights,attestation,batch,cost-management,netapp,synapse (Azure#15000)
openapi-sdkautomation bot
pushed a commit
to AzureSDKAutomation/azure-sdk-for-java
that referenced
this pull request
Jun 28, 2021
alertsmanagement,applicationinsights,attestation,batch,cost-management,netapp,synapse (Azure#15000)
openapi-sdkautomation bot
pushed a commit
to AzureSDKAutomation/azure-sdk-for-java
that referenced
this pull request
Jun 28, 2021
alertsmanagement,applicationinsights,attestation,batch,cost-management,netapp,synapse (Azure#15000)
openapi-sdkautomation bot
pushed a commit
to AzureSDKAutomation/azure-sdk-for-java
that referenced
this pull request
Jun 28, 2021
alertsmanagement,applicationinsights,attestation,batch,cost-management,netapp,synapse (Azure#15000)
openapi-sdkautomation bot
pushed a commit
to AzureSDKAutomation/azure-sdk-for-java
that referenced
this pull request
Jun 28, 2021
alertsmanagement,applicationinsights,attestation,batch,cost-management,netapp,synapse (Azure#15000)
openapi-sdkautomation bot
pushed a commit
to AzureSDKAutomation/azure-sdk-for-java
that referenced
this pull request
Jun 28, 2021
alertsmanagement,applicationinsights,attestation,batch,cost-management,netapp,synapse (Azure#15000)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Data is now a parameter in the constructor, and does not have a setter method. This more closely follows the Event Grid Event spec, which requires that data be set. However, there is no verification/null checking of the data on the SDK side.
Closes #14922