-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dump Heap on OOM and Retain Heap Dump #18392
Dump Heap on OOM and Retain Heap Dump #18392
Conversation
/azp run java - core |
Azure Pipelines successfully started running 1 pipeline(s). |
…rectory to allow multiple heap dumps to happen
…her investigation
This pull request is protected by Check Enforcer. What is Check Enforcer?Check Enforcer helps ensure all pull requests are covered by at least one check-run (typically an Azure Pipeline). When all check-runs associated with this pull request pass then Check Enforcer itself will pass. Why am I getting this message?You are getting this message because Check Enforcer did not detect any check-runs being associated with this pull request within five minutes. This may indicate that your pull request is not covered by any pipelines and so Check Enforcer is correctly blocking the pull request being merged. What should I do now?If the check-enforcer check-run is not passing and all other check-runs associated with this PR are passing (excluding license-cla) then you could try telling Check Enforcer to evaluate your pull request again. You can do this by adding a comment to this pull request as follows: What if I am onboarding a new service?Often, new services do not have validation pipelines associated with them, in order to bootstrap pipelines for a new service, you can issue the following command as a pull request comment: |
@alzimmermsft status update? |
/azp run java - core |
Azure Pipelines successfully started running 1 pipeline(s). |
<!-- This property determines the max heap size of the Surefire JVM. By default 3GB, or 3096MB, is used. --> | ||
<surefireXmx>3096m</surefireXmx> | ||
|
||
<!-- This property configures the max heap size of the Surefire JVM. --> | ||
<surefireJvmXmx>-Xmx${surefireXmx}</surefireJvmXmx> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can this collide with
azure-sdk-for-java/sdk/storage/azure-storage-blob/pom.xml
Lines 236 to 238 in da6337e
<argLine> | |
-Xmx6g | |
</argLine> |
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, this can collide with that. The thought behind the new pattern is to override <surefireXmx>3096m</surefireXmx>
to a new value in the child POM, so in this case it would be <surefireXmx>6g</surefireXmx>
in azure-storage-blob/pom.xml
. This will then be rolled into the <surefireJvmXmx>
value and passed into the maven-surefire-plugin
argLine
.
Overall, the changes are to use more composition-esque styling by overriding property values instead of overriding plugin configurations (as these have shown to be much more brittle).
This PR adds support for CI pipelines to dump heap on OutOfMemoryError and retain the hprof as a pipeline artifact. Additionally, this introduces a new pattern for configuring
maven-surefire-plugin
'sargLine
configuration.