Adding perf improvements for ObjectNode mapping #18859
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FabianMeiswinkel
requested review from
kirankumarkolli,
kushagraThapar,
mbhaskar,
milismsft,
moderakh,
simplynaveen20 and
xinlian12
as code owners
ghost
added
the
|
|
moderakh
reviewed
Jan 28, 2021
| @@ -1211,6 +1211,8 @@ private void addPartitionKeyInformation(RxDocumentServiceRequest request, | |||
| InternalObjectNode internalObjectNode; | |||
| if (objectDoc instanceof InternalObjectNode) { | |||
| internalObjectNode = (InternalObjectNode) objectDoc; | |||
| } else if (objectDoc instanceof ObjectNode) { | |||
| internalObjectNode = new InternalObjectNode((ObjectNode)objectDoc); | |||
There was a problem hiding this comment.
we would like to move away from the notion of InternalObjectNode and delete this class altogether.
Currently InternalObjectNode is not used in the Point read/write. It is only used in the CFP code path.
With this change we are adding more dependency on InternalObjectNode
can we do the other way around and replace InternalObjectNode with ObjectNode?
moderakh
approved these changes
Jan 28, 2021
azure-sdk
pushed a commit
to azure-sdk/azure-sdk-for-java
that referenced
this pull request
Apr 29, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the possible perf improvement I found when working on the Retriable Write prototype
Also added a Perf test to proof that it actually improves throughput :-)