Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add module for jca integration test. #20810

Merged
merged 48 commits into from
May 13, 2021
Merged

Add module for jca integration test. #20810

merged 48 commits into from
May 13, 2021

Conversation

han-gao
Copy link
Contributor

@han-gao han-gao commented Apr 20, 2021 •
edited
Loading

Create a new module for jca integration test.

@ghost ghost added KeyVault azure-spring All azure-spring related issues labels Apr 20, 2021
Merge branch 'master' of git://github.com/Azure/azure-sdk-for-java in…
d205404 
…to add_modle_for_jca_integration_test

# Conflicts:
#	sdk/keyvault/azure-security-test-keyvault-jca/src/test/java/com/azure/security/keyvault/jca/AuthClientIT.java
#	sdk/keyvault/azure-security-test-keyvault-jca/src/test/java/com/azure/security/keyvault/jca/KeyVaultJcaProviderIT.java
#	sdk/keyvault/azure-security-test-keyvault-jca/src/test/java/com/azure/security/keyvault/jca/KeyVaultKeyStoreIT.java
#	sdk/keyvault/azure-security-test-keyvault-jca/src/test/java/com/azure/security/keyvault/jca/KeyVaultLoadStoreParameterIT.java
#	sdk/keyvault/azure-security-test-keyvault-jca/src/test/java/com/azure/security/keyvault/jca/ServerSocketIT.java
@check-enforcer
Copy link

This pull request is protected by Check Enforcer.

What is Check Enforcer?

Check Enforcer helps ensure all pull requests are covered by at least one check-run (typically an Azure Pipeline). When all check-runs associated with this pull request pass then Check Enforcer itself will pass.

Why am I getting this message?

You are getting this message because Check Enforcer did not detect any check-runs being associated with this pull request within five minutes. This may indicate that your pull request is not covered by any pipelines and so Check Enforcer is correctly blocking the pull request being merged.

What should I do now?

If the check-enforcer check-run is not passing and all other check-runs associated with this PR are passing (excluding license-cla) then you could try telling Check Enforcer to evaluate your pull request again. You can do this by adding a comment to this pull request as follows:
/check-enforcer evaluate
Typically evaulation only takes a few seconds. If you know that your pull request is not covered by a pipeline and this is expected you can override Check Enforcer using the following command:
/check-enforcer override
Note that using the override command triggers alerts so that follow-up investigations can occur (PRs still need to be approved as normal).

What if I am onboarding a new service?

Often, new services do not have validation pipelines associated with them, in order to bootstrap pipelines for a new service, you can issue the following command as a pull request comment:
/azp run prepare-pipelines
This will run a pipeline that analyzes the source tree and creates the pipelines necessary to build and validate your pull request. Once the pipeline has been created you can trigger the pipeline using the following comment:
/azp run java - [service] - ci

@backwind1233
Copy link
Contributor

/azp run java - keyvault - tests

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@yiliuTo
Copy link
Member

yiliuTo commented May 7, 2021

/azp run java - keyvault - tests

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

yiliuTo
yiliuTo requested changes May 7, 2021
View reviewed changes
...security-test-keyvault-jca/src/test/java/com/azure/security/keyvault/jca/AuthClientTest.java Show resolved Hide resolved
...rity-test-keyvault-jca/src/test/java/com/azure/security/keyvault/jca/KeyVaultClientTest.java Outdated Show resolved Hide resolved
...rity-test-keyvault-jca/src/test/java/com/azure/security/keyvault/jca/KeyVaultClientTest.java Show resolved Hide resolved
...rity-test-keyvault-jca/src/test/java/com/azure/security/keyvault/jca/KeyVaultClientTest.java Show resolved Hide resolved
...test-keyvault-jca/src/test/java/com/azure/security/keyvault/jca/KeyVaultJcaProviderTest.java Outdated Show resolved Hide resolved
...test-keyvault-jca/src/test/java/com/azure/security/keyvault/jca/KeyVaultJcaProviderTest.java Show resolved Hide resolved
...-test-keyvault-jca/src/test/java/com/azure/security/keyvault/jca/KeyVaultKeyManagerTest.java Outdated Show resolved Hide resolved
...-test-keyvault-jca/src/test/java/com/azure/security/keyvault/jca/KeyVaultKeyManagerTest.java Outdated Show resolved Hide resolved
...-test-keyvault-jca/src/test/java/com/azure/security/keyvault/jca/KeyVaultKeyManagerTest.java Show resolved Hide resolved
yiliuTo
yiliuTo requested changes May 7, 2021
View reviewed changes
...-test-keyvault-jca/src/test/java/com/azure/security/keyvault/jca/KeyVaultKeyManagerTest.java Show resolved Hide resolved
...-test-keyvault-jca/src/test/java/com/azure/security/keyvault/jca/KeyVaultKeyManagerTest.java Show resolved Hide resolved
...ty-test-keyvault-jca/src/test/java/com/azure/security/keyvault/jca/KeyVaultKeyStoreTest.java Show resolved Hide resolved
...ty-test-keyvault-jca/src/test/java/com/azure/security/keyvault/jca/KeyVaultKeyStoreTest.java Show resolved Hide resolved
...ty-test-keyvault-jca/src/test/java/com/azure/security/keyvault/jca/KeyVaultKeyStoreTest.java Show resolved Hide resolved
...ty-test-keyvault-jca/src/test/java/com/azure/security/keyvault/jca/KeyVaultKeyStoreTest.java Show resolved Hide resolved
...ty-test-keyvault-jca/src/test/java/com/azure/security/keyvault/jca/KeyVaultKeyStoreTest.java Show resolved Hide resolved
...ty-test-keyvault-jca/src/test/java/com/azure/security/keyvault/jca/KeyVaultKeyStoreTest.java Show resolved Hide resolved
...ty-test-keyvault-jca/src/test/java/com/azure/security/keyvault/jca/KeyVaultKeyStoreTest.java Outdated Show resolved Hide resolved
...ty-test-keyvault-jca/src/test/java/com/azure/security/keyvault/jca/KeyVaultKeyStoreTest.java Show resolved Hide resolved
@yiliuTo
Copy link
Member

yiliuTo commented May 12, 2021

/azp run java - keyvault - tests

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@yiliuTo
Copy link
Member

yiliuTo commented May 13, 2021

/azp run java - keyvault - tests

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

yiliuTo
yiliuTo approved these changes May 13, 2021
View reviewed changes
Copy link
Member

@yiliuTo yiliuTo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please update the code with above unresolved comments in another PR.

@yiliuTo
Copy link
Member

yiliuTo commented May 13, 2021

/check-enforcer override

backwind1233
backwind1233 approved these changes May 13, 2021
View reviewed changes
Copy link
Contributor

@backwind1233 backwind1233 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yiliuTo yiliuTo merged commit 2e0294b into Azure:master May 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stliu stliu stliu left review comments

@backwind1233 backwind1233 backwind1233 approved these changes

@yiliuTo yiliuTo yiliuTo approved these changes

@chenrujun chenrujun Awaiting requested review from chenrujun

@g2vinay g2vinay Awaiting requested review from g2vinay

@jialindai jialindai Awaiting requested review from jialindai

@samvaity samvaity Awaiting requested review from samvaity

@saragluna saragluna Awaiting requested review from saragluna

@vcolin7 vcolin7 Awaiting requested review from vcolin7

@alzimmermsft alzimmermsft Awaiting requested review from alzimmermsft

@danieljurek danieljurek Awaiting requested review from danieljurek

@JimSuplizio JimSuplizio Awaiting requested review from JimSuplizio

@mitchdenny mitchdenny Awaiting requested review from mitchdenny

@benbp benbp Awaiting requested review from benbp

@weshaggard weshaggard Awaiting requested review from weshaggard

Assignees
No one assigned
Labels
azure-spring All azure-spring related issues KeyVault
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@han-gao @vcolin7 @chenrujun @srnagar @yiliuTo @backwind1233 @stliu