Integration test scenario for Service Bus binder #21330
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
ZhuXiaoBing-cn
commented
May 12, 2021
ZhuXiaoBing-cn
commented
- Add ServiceBus binder integration tests.
ZhuXiaoBing-cn
requested review from
backwind1233,
chenrujun,
saragluna,
stliu and
yiliuTo
as code owners
ghost
added
the
|
/azp run java - spring - tests |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run java - spring - tests |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run java - spring - tests |
|
Azure Pipelines successfully started running 1 pipeline(s). |
ZhuXiaoBing-cn
requested review from
alzimmermsft,
danieljurek,
g2vinay,
JimSuplizio,
mitchdenny and
samvaity
as code owners
|
/azp run java - spring - tests |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run java - spring - tests |
|
Azure Pipelines successfully started running 1 pipeline(s). |
ZhuXiaoBing-cn
changed the title
saragluna
requested changes
May 14, 2021
# Conflicts: # sdk/spring/pom.xml
stliu
reviewed
May 18, 2021
...src/test/java/com/azure/spring/sample/servicebus/binder/ServiceBusQueueAndTopicBinderIT.java
Outdated
Show resolved
Hide resolved
|
/azp run java - spring - tests |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run java - spring - tests |
|
Azure Pipelines successfully started running 1 pipeline(s). |
saragluna
reviewed
May 26, 2021
|
/azp run java - spring - tests |
|
Azure Pipelines successfully started running 1 pipeline(s). |
saragluna
requested changes
May 27, 2021
...src/test/java/com/azure/spring/sample/servicebus/binder/ServiceBusQueueAndTopicBinderIT.java
Outdated
Show resolved
Hide resolved
|
/azp run java - spring - tests |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run java - spring - tests |
|
Azure Pipelines successfully started running 1 pipeline(s). |
saragluna
approved these changes
May 27, 2021
There was a problem hiding this comment.
LGTM. @ZhuXiaoBing-cn, let's create another PR to use different connection strings for two binnders.
|
Use different connection strings for ServiceBus binders integration tests. #21966 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.