Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleaning up MA APIs before GA #22336

Merged
merged 5 commits into from
Jun 22, 2021
Merged

Cleaning up MA APIs before GA #22336

merged 5 commits into from
Jun 22, 2021

Conversation

anuchandy
Copy link
Member

  • Removal of the word "Anomaly" from (get|list|create|deelte|update)AnomalyAlertConfig() APIs.
  • Rename of MetricAnomalyAlertConfiguration to MetricAlertConfiguration.
  • Rename DetectionConditionsOperator to DetectionConditionOperator
  • Rename AnomalyAlertConfiguration.dimensionsToSplitAlert property to dimensionsToSplitAlert
  • Adding [get|set]adminEmail() to Hook
  • Removal of add** methods (that adds to list properties) from couple of models

@check-enforcer
Copy link

This pull request is protected by Check Enforcer.

What is Check Enforcer?

Check Enforcer helps ensure all pull requests are covered by at least one check-run (typically an Azure Pipeline). When all check-runs associated with this pull request pass then Check Enforcer itself will pass.

Why am I getting this message?

You are getting this message because Check Enforcer did not detect any check-runs being associated with this pull request within five minutes. This may indicate that your pull request is not covered by any pipelines and so Check Enforcer is correctly blocking the pull request being merged.

What should I do now?

If the check-enforcer check-run is not passing and all other check-runs associated with this PR are passing (excluding license-cla) then you could try telling Check Enforcer to evaluate your pull request again. You can do this by adding a comment to this pull request as follows:
/check-enforcer evaluate
Typically evaulation only takes a few seconds. If you know that your pull request is not covered by a pipeline and this is expected you can override Check Enforcer using the following command:
/check-enforcer override
Note that using the override command triggers alerts so that follow-up investigations can occur (PRs still need to be approved as normal).

What if I am onboarding a new service?

Often, new services do not have validation pipelines associated with them, in order to bootstrap pipelines for a new service, you can issue the following command as a pull request comment:
/azp run prepare-pipelines
This will run a pipeline that analyzes the source tree and creates the pipelines necessary to build and validate your pull request. Once the pipeline has been created you can trigger the pipeline using the following comment:
/azp run java - [service] - ci

@anuchandy anuchandy marked this pull request as ready for review June 21, 2021 19:28
@weshaggard weshaggard closed this Jun 21, 2021
@weshaggard weshaggard reopened this Jun 21, 2021
@anuchandy
Copy link
Member Author

/check-enforcer evaluate

@anuchandy
Copy link
Member Author

/azp run java - metricsadvisor - ci

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@anuchandy
Copy link
Member Author

/azp run java - metricsadvisor - ci

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@anuchandy anuchandy requested a review from samvaity June 21, 2021 23:45
@anuchandy anuchandy enabled auto-merge (squash) June 21, 2021 23:46
@anuchandy
Copy link
Member Author

/azp run java - metricsadvisor - ci

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@anuchandy anuchandy enabled auto-merge (squash) June 22, 2021 00:07
@anuchandy
Copy link
Member Author

/azp run java - metricsadvisor - ci

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@anuchandy anuchandy merged commit 7b65a2f into Azure:main Jun 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants