Updated ServiceBusAdministrationClientBuilder to Support HttpPipelinePosition #23328
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alzimmermsft
added
Service Bus
Client
alzimmermsft
requested review from
anuchandy,
conniey,
jianghaolu,
ki1729,
lmolkova,
srnagar,
YijunXieMS and
yvgopal
as code owners
ghost
added
the
srnagar
reviewed
Aug 3, 2021
sdk/core/azure-core/src/main/java/com/azure/core/util/CoreUtils.java
Outdated
Show resolved
Hide resolved
...ava/com/azure/messaging/servicebus/administration/ServiceBusAdministrationClientBuilder.java
Show resolved
Hide resolved
srnagar
approved these changes
Aug 3, 2021
| public class ServiceBusAdministrationClientBuilderTest { | ||
|
|
||
| @Test | ||
| void buildClientDifferentApplicationIdTest() { |
There was a problem hiding this comment.
Any reason for deleting this file?
There was a problem hiding this comment.
This was the only test in the file but with the change to use ClientOptions, else HttpLogOptions without throwing the test no longer applied. This left the class without any tests
azure-sdk
pushed a commit
to azure-sdk/azure-sdk-for-java
that referenced
this pull request
Apr 4, 2023
added quota request example for Azure Lab Services (Azure#23328)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #15637