Fix CheckStyle issues in common/perf-test-core.
#24697
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vcolin7
changed the title
common/perf-test-core.common/perf-test-core.
alzimmermsft
approved these changes
Oct 8, 2021
I'd rather see the pipeline this folder triggers run Checkstyle's as there isn't much of a connection to Core. |
|
@alzimmermsft The thing is, why is CheckStyle going through |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes CheckStyle issues in
common/perf-test-coreintroduced in these PRs:I can't help but wonder if we should have the
azure - core - cipipeline for PRs that involve updates to code in this folder.