Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update test in azure-security-keyvault-jca #25393

Merged
merged 2 commits into from
Nov 15, 2021
Merged

update test in azure-security-keyvault-jca #25393

merged 2 commits into from
Nov 15, 2021

Conversation

chenrujun
Copy link

@chenrujun chenrujun commented Nov 15, 2021 •
edited
Loading

Description

Not all developer's develop environment can access https://google.com, but https://mvnrepository.com should be accessible.

All SDK Contribution checklist:

  • The pull request does not introduce [breaking changes]
  • CHANGELOG is updated for new features, bug fixes or other significant changes.
  • I have read the contribution guidelines.

General Guidelines and Best Practices

  • Title of the pull request is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

  • Pull request includes test coverage for the included changes.

@ghost ghost added KeyVault azure-spring All azure-spring related issues labels Nov 15, 2021
@chenrujun chenrujun changed the title Use https://mvnrepository.com instead of https://google.com to test http client. update test in azure-security-keyvault-jca Nov 15, 2021
@chenrujun chenrujun self-assigned this Nov 15, 2021
@chenrujun
Copy link
Author

Hi, @saragluna , please help to review this PR.

saragluna
saragluna approved these changes Nov 15, 2021
View reviewed changes
Copy link
Member

@saragluna saragluna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@chenrujun
Copy link
Author

/check-enforcer override

@chenrujun chenrujun merged commit b3f812a into Azure:main Nov 15, 2021
@chenrujun chenrujun deleted the update-test-in-azure-security-keyvault-jca branch November 15, 2021 02:01
XiaofeiCao pushed a commit to XiaofeiCao/azure-sdk-for-java that referenced this pull request Nov 18, 2021
@XiaofeiCao
update test in azure-security-keyvault-jca (Azure#25393)
2248e1d
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@saragluna saragluna saragluna approved these changes

@backwind1233 backwind1233 Awaiting requested review from backwind1233

@hui1110 hui1110 Awaiting requested review from hui1110

@jialigit jialigit Awaiting requested review from jialigit

@moarychan moarychan Awaiting requested review from moarychan moarychan is a code owner

@stliu stliu Awaiting requested review from stliu

@yiliuTo yiliuTo Awaiting requested review from yiliuTo

@g2vinay g2vinay Awaiting requested review from g2vinay g2vinay is a code owner

@samvaity samvaity Awaiting requested review from samvaity

@vcolin7 vcolin7 Awaiting requested review from vcolin7 vcolin7 is a code owner

Assignees

@chenrujun chenrujun

Labels
azure-spring All azure-spring related issues KeyVault
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@chenrujun @saragluna @rujche