Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more items in pom.xml. #25715

Merged
merged 14 commits into from
Nov 29, 2021
Merged

Add more items in pom.xml. #25715

merged 14 commits into from
Nov 29, 2021

Conversation

hui1110
Copy link
Contributor

@hui1110 hui1110 commented Nov 26, 2021

Add more items in pom.xml for spring related modules.

@ghost ghost added the azure-spring All azure-spring related issues label Nov 26, 2021
@hui1110 hui1110 linked an issue Nov 26, 2021 that may be closed by this pull request
@@ -32,7 +32,8 @@
<developers>
<developer>
<id>microsoft</id>
<name>Microsoft Corporation</name>
<name>Spring Cloud Azure</name>

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Delete extra space.

@@ -32,7 +32,8 @@
<developers>
<developer>
<id>microsoft</id>

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please uniform this content in all our pom files?
For example:

  1. Delete <id>.
  2. Put all contents together.

@hui1110 hui1110 marked this pull request as ready for review November 26, 2021 10:07
Copy link

@chenrujun chenrujun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@chenrujun
Copy link

Hi, @hui1110 , I approved this PR. Please merge it by yourself.

@hui1110 hui1110 merged commit 41baf77 into Azure:feature/azure-spring-cloud-4.0 Nov 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
azure-spring All azure-spring related issues
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FEATURE REQ] Add more items in pom.xml for spring related modules.
2 participants