Share files additional headers #28440
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rickle-msft
requested review from
amishra-dev,
jaschrep-msft,
alzimmermsft and
kasobol-msft
as code owners
ghost
added
the
|
API change check for API changes have been detected in |
...torage-file-share/src/main/java/com/azure/storage/file/share/models/FileLastWrittenMode.java
Show resolved
Hide resolved
...ge-file-share/src/main/java/com/azure/storage/file/share/options/ShareFileRenameOptions.java
Outdated
Show resolved
Hide resolved
kasobol-msft
approved these changes
Apr 27, 2022
Comment on lines
+195
to
+217
| public ShareFileRenameOptions setHeaders(ShareFileHttpHeaders headers) { | ||
| if (headers.getCacheControl() != null) { | ||
| throw LOGGER.logExceptionAsError( | ||
| new IllegalArgumentException("cache control is not supported on this api")); | ||
| } | ||
| if (headers.getContentDisposition() != null) { | ||
| throw LOGGER.logExceptionAsError( | ||
| new IllegalArgumentException("content disposition is not supported on this api")); | ||
| } | ||
| if (headers.getContentEncoding() != null) { | ||
| throw LOGGER.logExceptionAsError( | ||
| new IllegalArgumentException("content encoding is not supported on this api")); | ||
| } | ||
| if (headers.getContentLanguage() != null) { | ||
| throw LOGGER.logExceptionAsError( | ||
| new IllegalArgumentException("content language is not supported on this api")); | ||
| } | ||
| if (headers.getContentMd5() != null) { | ||
| throw LOGGER.logExceptionAsError( | ||
| new IllegalArgumentException("content md5 is not supported on this api")); | ||
| } | ||
| this.headers = headers; | ||
| return this; |
There was a problem hiding this comment.
let's merge it. but we should discuss this issue during api review.
There was a problem hiding this comment.
I vote we make ContentType a property on ShareFileRenameOptions
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.