-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Share files additional headers #28440
Share files additional headers #28440
Conversation
API change check for API changes have been detected in |
...torage-file-share/src/main/java/com/azure/storage/file/share/models/FileLastWrittenMode.java
Show resolved
Hide resolved
...ge-file-share/src/main/java/com/azure/storage/file/share/options/ShareFileRenameOptions.java
Outdated
Show resolved
Hide resolved
public ShareFileRenameOptions setHeaders(ShareFileHttpHeaders headers) { | ||
if (headers.getCacheControl() != null) { | ||
throw LOGGER.logExceptionAsError( | ||
new IllegalArgumentException("cache control is not supported on this api")); | ||
} | ||
if (headers.getContentDisposition() != null) { | ||
throw LOGGER.logExceptionAsError( | ||
new IllegalArgumentException("content disposition is not supported on this api")); | ||
} | ||
if (headers.getContentEncoding() != null) { | ||
throw LOGGER.logExceptionAsError( | ||
new IllegalArgumentException("content encoding is not supported on this api")); | ||
} | ||
if (headers.getContentLanguage() != null) { | ||
throw LOGGER.logExceptionAsError( | ||
new IllegalArgumentException("content language is not supported on this api")); | ||
} | ||
if (headers.getContentMd5() != null) { | ||
throw LOGGER.logExceptionAsError( | ||
new IllegalArgumentException("content md5 is not supported on this api")); | ||
} | ||
this.headers = headers; | ||
return this; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
let's merge it. but we should discuss this issue during api review.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I vote we make ContentType a property on ShareFileRenameOptions
No description provided.