Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Amqp] Moving tests using VirtualTimeScheduler to dedicated test classes to run them in sequential and isolated mode #29492

Merged
merged 4 commits into from
Jun 15, 2022

Conversation

anuchandy
Copy link
Member

@anuchandy anuchandy commented Jun 15, 2022

Copy link
Member

@alzimmermsft alzimmermsft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just need to add license headers

@azure-sdk
Copy link
Collaborator

API change check

API changes are not detected in this pull request.

Copy link
Contributor

@kasobol-msft kasobol-msft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@anuchandy can you put link to this PR in https://github.com/Azure/azure-sdk-for-java/wiki/Unit-Testing#stepverifierwithvirtualtime as reference implementation of isolation?

@anuchandy
Copy link
Member Author

Good point Kamil, will do it.

@kasobol-msft kasobol-msft merged commit a88aa28 into Azure:main Jun 15, 2022
khmic5 pushed a commit to daniel-rocha/azure-sdk-for-java that referenced this pull request Jun 19, 2022
…ses to run them in sequential and isolated mode (Azure#29492)

* Creating dedicated test class for tests using VirtualTimeScheduler for running them in sequential/isolated

* Adding license header

* Isolating ReactorReceiver test using VTS

* fixing checkstyle
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Azure.Core azure-core
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants