ADLS Gen 2 Append and Lease Operations #31263
Conversation
ibrahimrabab
requested review from
jaschrep-msft and
alzimmermsft
as code owners
ghost
added
the
|
API change check APIView has identified API level changes in this PR and created following API reviews. |
| /** | ||
| * @return the lease duration in seconds. | ||
| */ | ||
| public Integer getLeaseDuration() { |
There was a problem hiding this comment.
I'd rather see Duration used here to allow this to be more flexible on usage and avoid time as a number ambiguity (is it milliseconds, is it seconds, is it something else)
There was a problem hiding this comment.
It appears we are using int for lease duration in the DataLakeLeaseClient -
There was a problem hiding this comment.
I'm good with using Integer if we want to maintain internal consistency. In the future if we get feedback about it another overload using Duration could always be added, similar to what was done with RequestRetryOptions (#17628).
...datalake/src/main/java/com/azure/storage/file/datalake/options/DataLakeFileFlushOptions.java
Outdated
Show resolved
Hide resolved
...datalake/src/main/java/com/azure/storage/file/datalake/options/DataLakeFileFlushOptions.java
Show resolved
Hide resolved
| /** | ||
| * @return the lease duration in seconds. | ||
| */ | ||
| public Integer getLeaseDuration() { |
There was a problem hiding this comment.
It appears we are using int for lease duration in the DataLakeLeaseClient -
...datalake/src/main/java/com/azure/storage/file/datalake/options/DataLakeFileFlushOptions.java
Outdated
Show resolved
Hide resolved
...datalake/src/main/java/com/azure/storage/file/datalake/options/DataLakeFileFlushOptions.java
Show resolved
Hide resolved
Description
This PR aims to:
Acquisition & renewal of lease will be available with append API from HDFS endpoint.
Release of lease with flush on append.
Acquire-Release Mode introduced in append for small file write scenarios. Auto-renew, Acquire & Acquire-Release Mode will be introduced for flush so that intermittent/slow flushes succeed.
More information on this feature can be found in the following spec