Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

mgmt, digitaltwins, add live tests #35366

Closed
wants to merge 13 commits into from
Closed

mgmt, digitaltwins, add live tests #35366

wants to merge 13 commits into from

Conversation

v-hongli1
Copy link
Contributor

@v-hongli1 v-hongli1 commented Jun 8, 2023 •
edited
Loading

Description

Please add an informative description that covers that changes made by the pull request and link all relevant issues.

If an SDK is being regenerated based on a new swagger spec, a link to the pull request containing these swagger spec changes has been included above.

All SDK Contribution checklist:

  • The pull request does not introduce [breaking changes]
  • CHANGELOG is updated for new features, bug fixes or other significant changes.
  • I have read the contribution guidelines.

General Guidelines and Best Practices

  • Title of the pull request is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

  • Pull request includes test coverage for the included changes.

@azure-sdk
Copy link
Collaborator

API change check

API changes are not detected in this pull request.

@v-hongli1
Copy link
Contributor Author

/azp run prepare-pipelines

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@v-hongli1
Copy link
Contributor Author

/azp run java - digitaltwins - mgmt - tests

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@v-hongli1 v-hongli1 marked this pull request as ready for review June 8, 2023 06:01
weidongxu-microsoft
weidongxu-microsoft requested changes Jun 8, 2023
View reviewed changes
Copy link
Member

@weidongxu-microsoft weidongxu-microsoft left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need to hold on this.

This is the case that the service folder is shared with data-plane. And they already have their tests.yml and bicep ready.

We should not modify their bicep.

service that share track2 data-plane and mgmt-plane lib in same folder (especially those having data-plane test-resources.json/bicep), e.g. https://github.com/Azure/azure-sdk-for-java/tree/main/sdk/eventgrid

@weidongxu-microsoft
Copy link
Member

Could you start with these service that does not have data-plane?

@v-hongli1
Copy link
Contributor Author

/azp run java - digitaltwins - mgmt - tests

1 similar comment
@v-hongli1
Copy link
Contributor Author

/azp run java - digitaltwins - mgmt - tests

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@Azure Azure deleted a comment from azure-pipelines bot Jun 25, 2023
@Azure Azure deleted a comment from azure-pipelines bot Jun 25, 2023
@Azure Azure deleted a comment from azure-pipelines bot Jun 25, 2023
@Azure Azure deleted a comment from azure-pipelines bot Jun 25, 2023
@Azure Azure deleted a comment from azure-pipelines bot Jun 25, 2023
@Azure Azure deleted a comment from azure-pipelines bot Jun 25, 2023
@v-hongli1
Copy link
Contributor Author

/azp run java - digitaltwins - mgmt - tests

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@v-hongli1 v-hongli1 closed this Jul 5, 2023
@v-hongli1 v-hongli1 deleted the issue#35316_digitaltwins branch July 5, 2023 09:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@weidongxu-microsoft weidongxu-microsoft weidongxu-microsoft requested changes

@haolingdong-msft haolingdong-msft Awaiting requested review from haolingdong-msft haolingdong-msft is a code owner

@XiaofeiCao XiaofeiCao Awaiting requested review from XiaofeiCao XiaofeiCao is a code owner

@ArthurMa1978 ArthurMa1978 Awaiting requested review from ArthurMa1978 ArthurMa1978 is a code owner

@johngallardo johngallardo Awaiting requested review from johngallardo johngallardo is a code owner

@abhinav-ghai abhinav-ghai Awaiting requested review from abhinav-ghai abhinav-ghai is a code owner

@Aashish93-stack Aashish93-stack Awaiting requested review from Aashish93-stack Aashish93-stack is a code owner

@sjiherzig sjiherzig Awaiting requested review from sjiherzig sjiherzig is a code owner

Assignees
No one assigned
Labels
Digital Twins
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@v-hongli1 @azure-sdk @weidongxu-microsoft