Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mgmt, iothub, add live tests #35371

Merged
merged 8 commits into from
Jun 9, 2023
Merged

mgmt, iothub, add live tests #35371

merged 8 commits into from
Jun 9, 2023

Conversation

v-hongli1
Copy link
Contributor

relate to #35316

Description

Please add an informative description that covers that changes made by the pull request and link all relevant issues.

If an SDK is being regenerated based on a new swagger spec, a link to the pull request containing these swagger spec changes has been included above.

All SDK Contribution checklist:

  • The pull request does not introduce [breaking changes]
  • CHANGELOG is updated for new features, bug fixes or other significant changes.
  • I have read the contribution guidelines.

General Guidelines and Best Practices

  • Title of the pull request is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

  • Pull request includes test coverage for the included changes.

@azure-sdk
Copy link
Collaborator

API change check

API changes are not detected in this pull request.

@Azure Azure deleted a comment from azure-pipelines bot Jun 8, 2023
@Azure Azure deleted a comment from azure-pipelines bot Jun 8, 2023
@Azure Azure deleted a comment from azure-pipelines bot Jun 9, 2023
@Azure Azure deleted a comment from azure-pipelines bot Jun 9, 2023
@v-hongli1
Copy link
Contributor Author

/azp run prepare-pipelines

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@v-hongli1
Copy link
Contributor Author

/azp run java - iothub - mgmt - tests

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@weidongxu-microsoft
Copy link
Member

weidongxu-microsoft commented Jun 9, 2023

Could you locally regen iothub with a stable api-version (don't commit, don't check-in, we just need the code of a working api-version to run test), and test locally that your live test passes?

api-version problem raised in https://github.com/Azure/sdk-release-request/issues/3974, but we need to make sure your live tests works on at least one api-version (where backend is good).

Copy link
Member

@weidongxu-microsoft weidongxu-microsoft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Please make sure your current test still pass the working api-version locally, before merge.

@v-hongli1 v-hongli1 merged commit 5e5831a into Azure:main Jun 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants