-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
mgmt, iothub, add live tests #35371
mgmt, iothub, add live tests #35371
Conversation
API change check API changes are not detected in this pull request. |
/azp run prepare-pipelines |
Azure Pipelines successfully started running 1 pipeline(s). |
/azp run java - iothub - mgmt - tests |
Azure Pipelines successfully started running 1 pipeline(s). |
...ager-iothub/src/test/java/com/azure/resourcemanager/iothub/generated/IotHubManagerTests.java
Outdated
Show resolved
Hide resolved
...ager-iothub/src/test/java/com/azure/resourcemanager/iothub/generated/IotHubManagerTests.java
Outdated
Show resolved
Hide resolved
...ager-iothub/src/test/java/com/azure/resourcemanager/iothub/generated/IotHubManagerTests.java
Outdated
Show resolved
Hide resolved
Could you locally regen iothub with a stable api-version (don't commit, don't check-in, we just need the code of a working api-version to run test), and test locally that your live test passes? api-version problem raised in https://github.com/Azure/sdk-release-request/issues/3974, but we need to make sure your live tests works on at least one api-version (where backend is good). |
...ager-iothub/src/test/java/com/azure/resourcemanager/iothub/generated/IotHubManagerTests.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
Please make sure your current test still pass the working api-version locally, before merge.
relate to #35316
Description
Please add an informative description that covers that changes made by the pull request and link all relevant issues.
If an SDK is being regenerated based on a new swagger spec, a link to the pull request containing these swagger spec changes has been included above.
All SDK Contribution checklist:
General Guidelines and Best Practices
Testing Guidelines