Initian design for OTHER status[DRAFT] #4015
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JonathanGiles
requested changes
Jun 20, 2019
| * which must never return {@code null}, and which must always have a non-null {@link com.azure.core.util.polling.PollResponse.OperationStatus}. | ||
| *{@link Mono} returned from poll operation should never return {@link Mono#error(Throwable)}.If any unexpected scenario happens in poll operation, | ||
| * @param pollInterval Not-null and greater than zero poll interval. | ||
| * @param pollOperation The polling operation to be called by the {@link Poller} instance. This is a callback into the client library, |
There was a problem hiding this comment.
Don't do this kind of alignment
There was a problem hiding this comment.
I have auto format in Intellij which I should turn off.
| //observeState.add(OperationStatus.State.FAILED); | ||
| this.fluxHandle = this.fluxHandle.filterWhen(tPollResponse -> matchesState(tPollResponse, observeState, observeOtherStates)); | ||
| return this.fluxHandle; | ||
| } |
There was a problem hiding this comment.
I don't think this API is necessary. The user can implement the filter on their side.
There was a problem hiding this comment.
That's true , makes poller simpler.
|
Be sure to refer back to the issue so context can be track - this PR is for issue #3930 |
| */ | ||
| public PollResponse(OperationStatus status, T value, Duration retryAfter, Map<Object, Object> properties) { | ||
| public PollResponse(OperationStatus status, String otherStatus, T value, Duration retryAfter, Map<Object, Object> properties) { |
There was a problem hiding this comment.
I would simplify the constructor - if the user has supplied an 'otherStatus', you don't need them to supply an operation status, you can automatically make that OTHER.
JonathanGiles
requested changes
Jun 20, 2019
added 9 commits
June 24, 2019 13:51
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is for design discussion for OTHER status. Test will fail since they are not updated.