Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mgmt, NetworkAnalytics, add live tests #40402

Merged
merged 8 commits into from
May 31, 2024

Conversation

v-hongli1
Copy link
Contributor

@v-hongli1 v-hongli1 commented May 30, 2024

relate to issue#35316

Description

Please add an informative description that covers that changes made by the pull request and link all relevant issues.

If an SDK is being regenerated based on a new swagger spec, a link to the pull request containing these swagger spec changes has been included above.

All SDK Contribution checklist:

  • The pull request does not introduce [breaking changes]
  • CHANGELOG is updated for new features, bug fixes or other significant changes.
  • I have read the contribution guidelines.

General Guidelines and Best Practices

  • Title of the pull request is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

  • Pull request includes test coverage for the included changes.

@github-actions github-actions bot added the Mgmt This issue is related to a management-plane library. label May 30, 2024
@v-hongli1 v-hongli1 force-pushed the issue#35316_networkanalytics branch from b02d2e8 to 83a5ef9 Compare May 30, 2024 03:51
@Azure Azure deleted a comment from azure-pipelines bot May 30, 2024
@Azure Azure deleted a comment from azure-pipelines bot May 30, 2024
@v-hongli1
Copy link
Contributor Author

/azp run java - networkanalytics - ci

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@Azure Azure deleted a comment from azure-pipelines bot May 30, 2024
@v-hongli1 v-hongli1 force-pushed the issue#35316_networkanalytics branch 2 times, most recently from 5565e21 to 6af226f Compare May 30, 2024 05:04
@Azure Azure deleted a comment from azure-pipelines bot May 30, 2024
@Azure Azure deleted a comment from azure-pipelines bot May 30, 2024
@v-hongli1
Copy link
Contributor Author

/azp run prepare-pipelines

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@v-hongli1
Copy link
Contributor Author

/azp run java - networkanalytics - mgmt - tests

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@v-hongli1 v-hongli1 force-pushed the issue#35316_networkanalytics branch from cb7c4b4 to eafb177 Compare May 30, 2024 06:20
@v-hongli1
Copy link
Contributor Author

/azp run java - networkanalytics - mgmt - tests

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@weidongxu-microsoft
Copy link
Member

weidongxu-microsoft commented May 31, 2024

@v-hongli1
And here it test in .NET
https://github.com/Azure/azure-sdk-for-net/blob/main/sdk/networkanalytics/Azure.ResourceManager.NetworkAnalytics/tests/NetworkAnalyticsManagementTestBase.cs#L45-L55

(it is possible that service team did this in their DogFood env, that no work in Prod; but worth a try)

@azure-sdk
Copy link
Collaborator

API change check

API changes are not detected in this pull request.

Copy link
Member

@weidongxu-microsoft weidongxu-microsoft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Give me a pipeline run of this mgmt - test

@Azure Azure deleted a comment from azure-pipelines bot May 31, 2024
@Azure Azure deleted a comment from azure-pipelines bot May 31, 2024
@Azure Azure deleted a comment from azure-pipelines bot May 31, 2024
@Azure Azure deleted a comment from azure-pipelines bot May 31, 2024
@Azure Azure deleted a comment from azure-pipelines bot May 31, 2024
@Azure Azure deleted a comment from azure-pipelines bot May 31, 2024
@Azure Azure deleted a comment from azure-pipelines bot May 31, 2024
@v-hongli1
Copy link
Contributor Author

/azp run prepare-pipelines

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@v-hongli1
Copy link
Contributor Author

/azp run java - networkanalytics - mgmt - tests

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@Azure Azure deleted a comment from azure-pipelines bot May 31, 2024
@Azure Azure deleted a comment from azure-pipelines bot May 31, 2024
@v-hongli1 v-hongli1 merged commit 3e8aed2 into Azure:main May 31, 2024
24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Mgmt This issue is related to a management-plane library.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants