Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change Netty version logging #40733

Merged
merged 4 commits into from
Jun 25, 2024

Conversation

alzimmermsft
Copy link
Member

Description

Fixes #40732

Changes how Netty version logging is performed to retain more metadata while inspecting Netty versions found in the class path and comparing them against what azure-core-http-netty specifies in its POM.

The only time Netty versions will be logged is when INFORMATIONAL logging, or more verbose, logging is enabled and there is a difference between the Netty versions specified in azure-core-http-netty and what was found on the class path. As before, this log is purely informational to help troubleshooting dependency conflicts, and the message will continue stating that. And, the message state to just align Netty versions, not to align them to what azure-core-http-netty is using, in case an older version of azure-core-http-netty is being used and CVEs are found in the versions of Netty it was released with.

Tests have been updated to fail if the versions listed in azure-core-http-netty's POM are forgotten to be updated when the dependency versions of Netty used change, this should prevent errant logs in the future when versions are upgraded and result in the message always being logged incorrectly.

All SDK Contribution checklist:

  • The pull request does not introduce [breaking changes]
  • CHANGELOG is updated for new features, bug fixes or other significant changes.
  • I have read the contribution guidelines.

General Guidelines and Best Practices

  • Title of the pull request is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

  • Pull request includes test coverage for the included changes.

@azure-sdk
Copy link
Collaborator

API change check

API changes are not detected in this pull request.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Azure.Core azure-core
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] azure-core-http-netty 1.15.1 contains wrong netty.version property
3 participants