Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #40732
Changes how Netty version logging is performed to retain more metadata while inspecting Netty versions found in the class path and comparing them against what
azure-core-http-netty
specifies in its POM.The only time Netty versions will be logged is when
INFORMATIONAL
logging, or more verbose, logging is enabled and there is a difference between the Netty versions specified inazure-core-http-netty
and what was found on the class path. As before, this log is purely informational to help troubleshooting dependency conflicts, and the message will continue stating that. And, the message state to just align Netty versions, not to align them to whatazure-core-http-netty
is using, in case an older version ofazure-core-http-netty
is being used and CVEs are found in the versions of Netty it was released with.Tests have been updated to fail if the versions listed in
azure-core-http-netty
's POM are forgotten to be updated when the dependency versions of Netty used change, this should prevent errant logs in the future when versions are upgraded and result in the message always being logged incorrectly.All SDK Contribution checklist:
General Guidelines and Best Practices
Testing Guidelines