Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate to use azure-servicebus-jms #42022

Merged
merged 8 commits into from
Oct 2, 2024
Merged

Migrate to use azure-servicebus-jms #42022

merged 8 commits into from
Oct 2, 2024

Conversation

Netyyyy
Copy link
Member

@Netyyyy Netyyyy commented Sep 25, 2024

Description

migrate to use azure-servicebus-jms

All SDK Contribution checklist:

  • The pull request does not introduce [breaking changes]
  • CHANGELOG is updated for new features, bug fixes or other significant changes.
  • I have read the contribution guidelines.

General Guidelines and Best Practices

  • Title of the pull request is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

  • Pull request includes test coverage for the included changes.

@github-actions github-actions bot added the azure-spring All azure-spring related issues label Sep 25, 2024
@azure-sdk
Copy link
Collaborator

azure-sdk commented Sep 25, 2024 •
edited
Loading

API change check

API changes are not detected in this pull request.

@Netyyyy
Copy link
Member Author

Netyyyy commented Sep 26, 2024

/azp run java - spring - tests

@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@Netyyyy
Copy link
Member Author

Netyyyy commented Sep 27, 2024

/azp run java - spring - tests

@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@Netyyyy
Copy link
Member Author

Netyyyy commented Sep 27, 2024

/azp run java - spring - tests

@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

saragluna
saragluna reviewed Sep 29, 2024
View reviewed changes
Copy link
Member

@saragluna saragluna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • We should remove the passwordless configuration class
  • We'd better test the standard tier (both password and passwordless
  • We should test both password and passwordless for premium.

.../com/azure/spring/cloud/autoconfigure/implementation/jms/ServiceBusJmsAutoConfiguration.java Show resolved Hide resolved
...ure/spring/cloud/autoconfigure/implementation/jms/ServiceBusJmsConnectionFactoryFactory.java Show resolved Hide resolved
...re/spring/cloud/autoconfigure/implementation/jms/ServiceBusJmsPasswordlessConfiguration.java Outdated Show resolved Hide resolved
@Netyyyy
Copy link
Member Author

Netyyyy commented Sep 30, 2024

/azp run java - spring - tests

@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@Netyyyy Netyyyy marked this pull request as ready for review September 30, 2024 08:09
@Netyyyy Netyyyy enabled auto-merge (squash) September 30, 2024 08:51
@Netyyyy Netyyyy disabled auto-merge October 1, 2024 01:51
@Netyyyy Netyyyy enabled auto-merge (squash) October 1, 2024 01:58
@Netyyyy
Copy link
Member Author

Netyyyy commented Oct 1, 2024

Hi @alzimmermsft ,please help approve, thanks

@Netyyyy Netyyyy disabled auto-merge October 2, 2024 00:07
@Netyyyy
Copy link
Member Author

Netyyyy commented Oct 2, 2024

/check-enforcer override

@Netyyyy Netyyyy merged commit d9814b8 into Azure:main Oct 2, 2024
87 of 90 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@saragluna saragluna saragluna approved these changes

@alzimmermsft alzimmermsft alzimmermsft approved these changes

@samvaity samvaity Awaiting requested review from samvaity samvaity is a code owner

@g2vinay g2vinay Awaiting requested review from g2vinay g2vinay is a code owner

@JonathanGiles JonathanGiles Awaiting requested review from JonathanGiles JonathanGiles is a code owner

@rujche rujche Awaiting requested review from rujche rujche is a code owner

@moarychan moarychan Awaiting requested review from moarychan moarychan is a code owner

Assignees
No one assigned
Labels
azure-spring All azure-spring related issues
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Netyyyy @azure-sdk @saragluna @alzimmermsft