API change of the Azure Monitor exporter #42134
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeanbisutti
requested review from
mssfang,
JonathanGiles,
alzimmermsft,
srnagar,
rujche,
Netyyyy,
saragluna,
moarychan,
trask,
ramthi,
heyams and
harsimar
as code owners
github-actions
bot
added
azure-spring
|
API change check APIView has identified API level changes in this PR and created following API reviews. |
jeanbisutti
commented
Sep 30, 2024
...rter/src/main/java/com/azure/monitor/opentelemetry/exporter/AzureMonitorExporterOptions.java
Show resolved
Hide resolved
jeanbisutti
force-pushed
the
jean/azure-monitor-exporter-new-api
branch
from
3645c94
to
cac5605
Compare
jeanbisutti
requested review from
hallipr,
weshaggard,
JimSuplizio,
anuchandy,
conniey and
lmolkova
as code owners
trask
approved these changes
Sep 30, 2024
...rter/src/main/java/com/azure/monitor/opentelemetry/exporter/AzureMonitorExporterOptions.java
Show resolved
Hide resolved
heyams
reviewed
Sep 30, 2024
...venthubs-stress/src/main/java/com/azure/messaging/eventhubs/stress/util/TelemetryHelper.java
Show resolved
Hide resolved
...ry-exporter/src/main/java/com/azure/monitor/opentelemetry/exporter/AzureMonitorExporter.java
Show resolved
Hide resolved
...ry-exporter/src/main/java/com/azure/monitor/opentelemetry/exporter/AzureMonitorExporter.java
Show resolved
Hide resolved
srnagar
reviewed
Sep 30, 2024
...rter/src/main/java/com/azure/monitor/opentelemetry/exporter/AzureMonitorExporterOptions.java
Show resolved
Hide resolved
...rter/src/main/java/com/azure/monitor/opentelemetry/exporter/AzureMonitorExporterOptions.java
Show resolved
Hide resolved
...ry-exporter/src/main/java/com/azure/monitor/opentelemetry/exporter/AzureMonitorExporter.java
Show resolved
Hide resolved
.../azure/monitor/opentelemetry/exporter/implementation/AzureMonitorMetricExporterProvider.java
Outdated
Show resolved
Hide resolved
...om/azure/monitor/opentelemetry/exporter/implementation/AzureMonitorSpanExporterProvider.java
Outdated
Show resolved
Hide resolved
lmolkova
reviewed
Oct 1, 2024
...rter/src/main/java/com/azure/monitor/opentelemetry/exporter/AzureMonitorExporterOptions.java
Outdated
Show resolved
Hide resolved
...nitor-opentelemetry-exporter/src/main/java/com/azure/monitor/opentelemetry/package-info.java
Show resolved
Hide resolved
…/com/azure/monitor/opentelemetry/exporter/AzureMonitorExporterOptions.java Co-authored-by: Liudmila Molkova <[email protected]>
lmolkova
approved these changes
Oct 1, 2024
There was a problem hiding this comment.
I'd be nice to address https://github.com/Azure/azure-sdk-for-java/pull/42134/files#r1781690171 in this PR, looks great otherwise!
...rter/src/main/java/com/azure/monitor/opentelemetry/exporter/AzureMonitorExporterOptions.java
Show resolved
Hide resolved
srnagar
approved these changes
Oct 1, 2024
|
/check-enforcer override |
LogsIngestionAsyncClientTest.testUploadLogsInBatches seems flaky on macOS |
This was referenced Oct 2, 2024
mssfang
pushed a commit
to mssfang/azure-sdk-for-java
that referenced
this pull request
Oct 21, 2024
* API change of the Azure Monitor exporter
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
AzureMonitor=>AzureMonitorExporterAzureMonitorExporterBuilder=>AzureMonitorExporterOptions(build exporter methods not public, implementation of the HTTP traits removed bur methods not renamed)AzureMonitorExporter(previouslyAzureMonitorExporterBuilder) moved to thecom.azure.monitor.opentelemetry.exporterpackage)