New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

mgmt, computefleet, add live tests #42311

Merged

XiaofeiCao merged 8 commits into Azure:main from v-hongli1:issue#35316_computefleet

Oct 16, 2024

Contributor

v-hongli1 commented Oct 14, 2024 •

edited

Loading

[FEATURE REQ] LIVE test for mgmt GA Lite packages #35316

Description

Please add an informative description that covers that changes made by the pull request and link all relevant issues.

If an SDK is being regenerated based on a new swagger spec, a link to the pull request containing these swagger spec changes has been included above.

All SDK Contribution checklist:

The pull request does not introduce [breaking changes]
CHANGELOG is updated for new features, bug fixes or other significant changes.
I have read the contribution guidelines.

General Guidelines and Best Practices

Title of the pull request is clear and informative.
There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

Pull request includes test coverage for the included changes.

github-actions bot added the Mgmt label

Collaborator

azure-sdk commented Oct 14, 2024

API change check

API changes are not detected in this pull request.

Contributor Author

v-hongli1 commented Oct 14, 2024

/azp run prepare-pipelines

azure-pipelines bot commented Oct 14, 2024

Azure Pipelines successfully started running 1 pipeline(s).

Contributor Author

v-hongli1 commented Oct 14, 2024

/azp run java - computefleet - mgmt - tests

azure-pipelines bot commented Oct 14, 2024

Azure Pipelines successfully started running 1 pipeline(s).

Contributor Author

v-hongli1 commented Oct 14, 2024

/azp run java - computefleet - mgmt - tests

azure-pipelines bot commented Oct 14, 2024

Azure Pipelines successfully started running 1 pipeline(s).


          mgmt, computefleet, add live tests

831e164

v-hongli1 force-pushed the issue#35316_computefleet branch from cc1bb06 to 831e164 Compare

October 14, 2024 08:16

Azure deleted a comment from azure-pipelines bot

Contributor Author

v-hongli1 commented Oct 14, 2024

/azp run java - computefleet - mgmt - tests

azure-pipelines bot commented Oct 14, 2024

Azure Pipelines successfully started running 1 pipeline(s).

v-hongli1 marked this pull request as ready for review

October 14, 2024 09:09

v-hongli1 requested review from weidongxu-microsoft, haolingdong-msft, XiaofeiCao, ArthurMa1978, joshfree, srnagar, anuchandy, conniey, lmolkova and JonathanGiles as code owners

October 14, 2024 09:09

weidongxu-microsoft reviewed

View reviewed changes

...putefleet/src/test/java/com/azure/resourcemanager/computefleet/ComputeFleetManagerTests.java Outdated Show resolved Hide resolved

XiaofeiCao reviewed

View reviewed changes

...putefleet/src/test/java/com/azure/resourcemanager/computefleet/ComputeFleetManagerTests.java Outdated Show resolved Hide resolved


          Fixed comments for pr#42311

628306a

Contributor Author

v-hongli1 commented Oct 15, 2024

/azp run java - computefleet - mgmt - tests

azure-pipelines bot commented Oct 15, 2024

Azure Pipelines successfully started running 1 pipeline(s).

weidongxu-microsoft reviewed

View reviewed changes

...putefleet/src/test/java/com/azure/resourcemanager/computefleet/ComputeFleetManagerTests.java Outdated Show resolved Hide resolved


          Fixed comments for pr#42311 and add code for register providers.

433ccd4

v-hongli1 force-pushed the issue#35316_computefleet branch from 97961ec to 433ccd4 Compare

October 15, 2024 07:32

Contributor Author

v-hongli1 commented Oct 15, 2024

/azp run java - computefleet - mgmt - tests

azure-pipelines bot commented Oct 15, 2024

Azure Pipelines successfully started running 1 pipeline(s).

Contributor Author

v-hongli1 commented Oct 15, 2024

/azp run java - computefleet - mgmt - tests

azure-pipelines bot commented Oct 15, 2024

Azure Pipelines successfully started running 1 pipeline(s).

v-hongli1 force-pushed the issue#35316_computefleet branch from b3a4c1a to 433ccd4 Compare

October 15, 2024 08:32


          Fix live test exception.

01b83ae

Contributor Author

v-hongli1 commented Oct 15, 2024

/azp run java - computefleet - mgmt - tests

azure-pipelines bot commented Oct 15, 2024

Azure Pipelines successfully started running 1 pipeline(s).

XiaofeiCao reviewed

View reviewed changes

...putefleet/src/test/java/com/azure/resourcemanager/computefleet/ComputeFleetManagerTests.java Outdated Show resolved Hide resolved

v-hongli1 requested review from weidongxu-microsoft and XiaofeiCao

October 15, 2024 09:30


          Fixed comments for pr#42311.

357bb48

Contributor Author

v-hongli1 commented Oct 15, 2024

/azp run java - computefleet - mgmt - tests

azure-pipelines bot commented Oct 15, 2024

Azure Pipelines successfully started running 1 pipeline(s).

weidongxu-microsoft approved these changes

View reviewed changes

XiaofeiCao reviewed

View reviewed changes

...putefleet/src/test/java/com/azure/resourcemanager/computefleet/ComputeFleetManagerTests.java Outdated Show resolved Hide resolved

v-hongli1 added 2 commits

October 16, 2024 10:40


          Fix comment for PR#42311

2668de3


          Change to // @embedmeStart and // @embedmeEnd"

ee626f9

XiaofeiCao approved these changes

View reviewed changes

v-hongli1 requested review from weidongxu-microsoft and XiaofeiCao

October 16, 2024 03:53

v-hongli1 enabled auto-merge (squash)

October 16, 2024 04:29

v-hongli1 disabled auto-merge

October 16, 2024 04:31

Contributor Author

v-hongli1 commented Oct 16, 2024

/azp run java - computefleet - ci

azure-pipelines bot commented Oct 16, 2024

Azure Pipelines successfully started running 1 pipeline(s).

XiaofeiCao merged commit 253a830 into Azure:main

23 checks passed

weshaggard reviewed

View reviewed changes

sdk/computefleet/tests.mgmt.yml

+                      groupId: com.azure.resourcemanager
+                      safeName: azureresourcemanagercomputefleet
+                  Clouds: 'Public'
+                  UseFederatedAuth: true

Member

weshaggard Oct 17, 2024

@weidongxu-microsoft where do we generate these files? I would like to update them to remove "Clouds" and "UseFederatedAuth" parameters because they are no necessary.

Member

weidongxu-microsoft Oct 18, 2024 •

edited

Loading

This file is handwritten.

I guess Hong copied it when your PR is not yet merged.

Doc points to example on main, so it should not happen again https://github.com/Azure/azure-sdk-for-java/blob/main/sdk/resourcemanager/docs/HOW_TO_ADD_LIVE_TESTS.md#add-pipeline-configuration

I've made a PR to clean it up. #42450
This is the only one found.

weidongxu-microsoft mentioned this pull request

mgmt, eng, clean test ci #42450

Merged

6 tasks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

weshaggard weshaggard left review comments

haolingdong-msft Awaiting requested review from haolingdong-msft haolingdong-msft is a code owner

ArthurMa1978 Awaiting requested review from ArthurMa1978 ArthurMa1978 is a code owner

joshfree Awaiting requested review from joshfree joshfree is a code owner

srnagar Awaiting requested review from srnagar srnagar is a code owner

anuchandy Awaiting requested review from anuchandy anuchandy is a code owner

conniey Awaiting requested review from conniey conniey is a code owner

lmolkova Awaiting requested review from lmolkova lmolkova is a code owner

JonathanGiles Awaiting requested review from JonathanGiles JonathanGiles is a code owner

weidongxu-microsoft Awaiting requested review from weidongxu-microsoft weidongxu-microsoft is a code owner

XiaofeiCao Awaiting requested review from XiaofeiCao XiaofeiCao is a code owner

Labels

Mgmt