-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
mgmt, support subnet addressprefixes #42524
Merged
XiaofeiCao
merged 9 commits into
Azure:main
from
XiaofeiCao:mgmt_support_subnet_addressprefixes
Oct 24, 2024
Merged
mgmt, support subnet addressprefixes #42524
XiaofeiCao
merged 9 commits into
Azure:main
from
XiaofeiCao:mgmt_support_subnet_addressprefixes
Oct 24, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Mgmt
This issue is related to a management-plane library.
label
Oct 23, 2024
API change check APIView has identified API level changes in this PR and created following API reviews. |
XiaofeiCao
requested review from
weidongxu-microsoft,
haolingdong-msft and
ArthurMa1978
as code owners
October 23, 2024 05:19
...e-resourcemanager-network/src/main/java/com/azure/resourcemanager/network/models/Subnet.java
Outdated
Show resolved
Hide resolved
...network/src/test/java/com/azure/resourcemanager/network/NetworkInterfaceOperationsTests.java
Outdated
Show resolved
Hide resolved
...network/src/test/java/com/azure/resourcemanager/network/NetworkInterfaceOperationsTests.java
Outdated
Show resolved
Hide resolved
XiaofeiCao
commented
Oct 23, 2024
...network/src/test/java/com/azure/resourcemanager/network/NetworkInterfaceOperationsTests.java
Show resolved
Hide resolved
weidongxu-microsoft
approved these changes
Oct 23, 2024
...e-resourcemanager-network/src/main/java/com/azure/resourcemanager/network/models/Subnet.java
Outdated
Show resolved
Hide resolved
@haolingdong-msft Could you also take a look? |
...network/src/test/java/com/azure/resourcemanager/network/NetworkInterfaceOperationsTests.java
Show resolved
Hide resolved
...nager-network/src/main/java/com/azure/resourcemanager/network/implementation/SubnetImpl.java
Outdated
Show resolved
Hide resolved
haolingdong-msft
approved these changes
Oct 24, 2024
...e-resourcemanager-network/src/main/java/com/azure/resourcemanager/network/models/Subnet.java
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
addressPrefixes
forSubnet
Decision
addressPrefixes
is preferred andaddressPrefix
is used as a fallback, for both implementation of the convenience layer correspondence.Context
addressPrefixes
is the recommended property, and it's not interchangeable withaddressPrefix
addressPrefix
will overrideaddressPrefixes
Please add an informative description that covers that changes made by the pull request and link all relevant issues.
If an SDK is being regenerated based on a new swagger spec, a link to the pull request containing these swagger spec changes has been included above.
All SDK Contribution checklist:
General Guidelines and Best Practices
Testing Guidelines