Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mgmt, support subnet addressprefixes #42524

Merged
merged 9 commits into from
Oct 24, 2024

Conversation

XiaofeiCao
Copy link
Contributor

@XiaofeiCao XiaofeiCao commented Oct 23, 2024

Description

Decision

  • For getter, service model property addressPrefixes is preferred and addressPrefix is used as a fallback, for both implementation of the convenience layer correspondence.
  • For setter, setting each property in convenience layer will nullify the other for service model.

Context

image

  • addressPrefixes is the recommended property, and it's not interchangeable with addressPrefix
  • according to my test, specifying either one of them during update will successfully update, but not both. if both are present, addressPrefix will override addressPrefixes

Please add an informative description that covers that changes made by the pull request and link all relevant issues.

If an SDK is being regenerated based on a new swagger spec, a link to the pull request containing these swagger spec changes has been included above.

All SDK Contribution checklist:

  • The pull request does not introduce [breaking changes]
  • CHANGELOG is updated for new features, bug fixes or other significant changes.
  • I have read the contribution guidelines.

General Guidelines and Best Practices

  • Title of the pull request is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

  • Pull request includes test coverage for the included changes.

@github-actions github-actions bot added the Mgmt This issue is related to a management-plane library. label Oct 23, 2024
@azure-sdk
Copy link
Collaborator

API change check

APIView has identified API level changes in this PR and created following API reviews.

com.azure.resourcemanager:azure-resourcemanager-network

@weidongxu-microsoft
Copy link
Member

@haolingdong-msft Could you also take a look?

@XiaofeiCao XiaofeiCao merged commit 0d7ef9d into Azure:main Oct 24, 2024
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Mgmt This issue is related to a management-plane library.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants