Get latest #6841
Merged
Get latest #6841
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added support for user-provided customized headers
- If build is cancelled due to agent timeout, some tests results may have already been generated and should still be published
- Aligns Java with other languages
* Added changeLog for azure-core
* 'connectionString' cannot be null or empty.
Allowed user to define KeyFilter and LabelFilter
…6813) * fixes wrong property file name and update headers for all json files
* Removes the repo capture logic since it is relatively expensive. * Move to condition for repo capture so we can do it easily in the future.
tzhanl
requested review from
alzimmermsft,
conniey,
danieljurek,
gapra-msft,
hemanttanwar,
jaschrep-msft,
jianghaolu,
JimSuplizio,
kushagraThapar,
mitchdenny,
moderakh and
mssfang
as code owners
tzhanl
requested review from
rickle-msft,
sima-zhu,
srnagar and
weshaggard
as code owners
|
@tzhanl Generally we want at least one person to review code before you merge into master. From the commits, next time, you may want to rebase your commits on top of the latest in master. This will prevent git from thinking you altered 124 different files and limit the scope of your changes. Could you also add a description to your PR title? I'm unsure of what feature your PR is adding. |
|
I agree with @conniey - please in the future ensure that you give your PRs descriptive titles and descriptions, even in cases such as these where you are just updating a branch. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.