Add some VM image code #688
Conversation
| this.version = version; | ||
| } | ||
|
|
||
| VirtualMachineImageImpl(String publisher, String offer, String sku, String version, VirtualMachineImageInner innerObject) { |
There was a problem hiding this comment.
In general, the name of the inner parameter in fluent models is "innerModel".
|
@milismsft Maybe I should remove the version from |
| WINDOWS_SERVER_2012_R2_DATACENTER("MicrosoftWindowsServer", "WindowsServer", "2012-R2-Datacenter", "4.0.20160430"), | ||
| WINDOWS_SERVER_2016_TECHNICAL_PREVIEW_WITH_CONTAINIERS("MicrosoftWindowsServer", "WindowsServer", "2016-Technical-Preview-with-Containers", "2016.0.20151118"), | ||
| WINDOWS_SERVER_TECHNICAL_PREVIEW("MicrosoftWindowsServer", "WindowsServer", "Windows-Server-Technical-Preview", "5.0.20160420"); | ||
|
|
There was a problem hiding this comment.
if we set version to 'latest', then server picks the latest image from the specific sku.
There was a problem hiding this comment.
Oh that's cool. But still I wonder if we should do that... If latest changes in the middle of a user deploying 100 VMs they will actually get different images.
There was a problem hiding this comment.
Setting the version to "latest" by default is ok as long as the user has an option to overwrite that/specify something different later on.
The scenario I'm thinking is when the user has a web app that he verified/tested against a particular version; he might not want to default "upgrade" to the latest version of the image because that is something he did not tested for and he does not want the risk associated with that.
There was a problem hiding this comment.
Few caveats with KnownVirtualMachineImage enum that we all aware of:
- This enum entries are likely to grow as Azure rollout support for new skus ( UBUNTU_16_04_LTS, UBUNTU_16_06_LTS, UBUNTU_17_01_LTS)
- If Azure drop support for a sku then we will have to remove it from the enum, that's a breaking change. (WINDOWS_SERVER_TECHNICAL_PREVIEW seems a candidate for this)
But anyway we have an enum for "regions" which also has the same issues, but rollout/removal of new regions is less often compared to skus.
No description provided.