Implement Digest Authorization Support #6954
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alzimmermsft
requested review from
JonathanGiles,
srnagar,
anuchandy and
jianghaolu
jianghaolu
reviewed
Dec 19, 2019
sdk/core/azure-core/src/main/java/com/azure/core/http/AuthorizationChallengeHandler.java
Outdated
Show resolved
Hide resolved
…roxy digest authentication support in Reactor Netty
srnagar
reviewed
Jan 28, 2020
sdk/core/azure-core/src/main/java/com/azure/core/util/AuthorizationChallengeHandler.java
Outdated
Show resolved
Hide resolved
sdk/core/azure-core/src/main/java/com/azure/core/util/AuthorizationChallengeHandler.java
Show resolved
Hide resolved
conniey
reviewed
Jan 28, 2020
...netty/src/main/java/com/azure/core/http/netty/implementation/ProxyAuthenticationHandler.java
Outdated
Show resolved
Hide resolved
conniey
reviewed
Jan 28, 2020
...netty/src/main/java/com/azure/core/http/netty/implementation/ProxyAuthenticationHandler.java
Outdated
Show resolved
Hide resolved
conniey
reviewed
Jan 28, 2020
...netty/src/main/java/com/azure/core/http/netty/implementation/ProxyAuthenticationHandler.java
Outdated
Show resolved
Hide resolved
anuchandy
reviewed
Jan 28, 2020
...netty/src/main/java/com/azure/core/http/netty/implementation/ProxyAuthenticationHandler.java
Outdated
Show resolved
Hide resolved
…izationChallengeHandler
srnagar
reviewed
Jan 30, 2020
...core-http-netty/src/main/java/com/azure/core/http/netty/implementation/HttpProxyHandler.java
Show resolved
Hide resolved
srnagar
approved these changes
Jan 30, 2020
|
@anuchandy @srnagar @JonathanGiles Mind reviewing the changes to the licensing file made in the last commit. |
anuchandy
approved these changes
Jan 30, 2020
srnagar
pushed a commit
to srnagar/azure-sdk-for-java
that referenced
this pull request
Feb 4, 2020
* Rough idea for Digest Proxy support * Rough implementation of RFC 2617 and 7616 * Finalize RGC 2617 and RFC 7616 implementation * Added tests and changes to code structure * Integrating authentication support into Reactor Netty and OkHttp * Using channel attributes to pass authorization information * Support passing proxy authentication header through context * Fixed incorrect formatting in Proxy-Authorization header, finalized proxy digest authentication support in Reactor Netty * Adding documentation * Reverted testing changes in AppConfiguration * Moved AuthorizationChallengeHandler into util * Additional tests for AuthorizationChallengeHandler * Fixed checkstyle issues * Fixing linting and test issues * Changes based on PR feedback * Fix linting issue * Removed tests that don't have configuration available * Removed accidental character * Unit tests for Netty HttpClient * Fixed invalid name casing * Additional Netty tests * Unit tests for OkHttp * Fixed invalid failing test and removed erroneous dependency * Renaming classes, updating licensing, and added more tests for authScheme * Fixed linting issues, synchronizing access to lastChallenge in AuthorizationChallengeHandler * Fixed linting issue * Added OkHttp tests for configuration based proxy * Revert to using AtomicReference * Updated licensing text to include Netty license * Add component governance manifest
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #6109
Digest authorization support is added to Azure Core by
AuthorizationChallengeHandler. This class handles responding to Basic and Digest authorization requests and is compliant with RFC 2617 and RFC 7616.